meson: 0.35.0 -> 0.40.0 #25244
Merged
meson: 0.35.0 -> 0.40.0 #25244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In configured builds other tools tries to call meson by directly passing meson tools directly to python. Since they were shell scripts due wrapping this failed
|
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rasendubi, @sternenseemann and @brandonedens to be potential reviewers. |
Mic92
commented
Apr 26, 2017
| pushd $out/bin | ||
| # undo shell wrapper as meson tools are called with python | ||
| for i in *; do | ||
| mv ".$i-wrapped" "$i" |
There was a problem hiding this comment.
this looks hacky too me, but I did not find a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In configured builds other tools tries to call meson by directly
passing meson tools directly to python. Since they were shell scripts
due wrapping this failed. (tested with systemd new build system: https://github.com/systemd/systemd/)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)