Build failure: nixos

[KiaraGrouwstra]

Steps To Reproduce

Steps to reproduce the behavior:

1. build master

Build log

if i had referenced the package noto-fonts-emoji myself:

sudo nixos-rebuild switch --flake .#$USER-hammer
warning: Git tree '/etc/nixos' is dirty
building the system configuration...
warning: Git tree '/etc/nixos' is dirty
trace: warning: rustPlatform.rust.cargo is deprecated. Use cargo instead.
trace: warning: rustPlatform.rust.rustc is deprecated. Use rustc instead.
error: builder for '/nix/store/a0jjpmyflz0pkghkbd9g5wkcwp1jxvz2-nixos-icons-2021-02-24.drv' failed with exit code 2;
       last 10 log lines:
       > no configure script, doing nothing
       > building
       > build flags: SHELL=/nix/store/lf0wpjrj8yx4gsmw2s3xfl58ixmqk8qa-bash-5.2-p15/bin/bash DESTDIR=/nix/store/43nglpyy7ippgm99x44wcnw6bzash57f-nixos-icons-2021-02-24 prefix=
       > make -C icons
       > make[1]: Entering directory '/build/source/icons'
       > convert -background none -resize 16x16 ../logo/nix-snowflake.svg 16x16/apps/nix-snowflake.png
       > convert: time limit exceeded `../logo/nix-snowflake.svg' @ fatal/cache.c/GetImagePixelCache/1707.
       > make[1]: *** [Makefile:22: 16x16/apps/nix-snowflake.png] Error 1
       > make[1]: Leaving directory '/build/source/icons'
       > make: *** [Makefile:14: icons] Error 2
       For full logs, run 'nix log /nix/store/a0jjpmyflz0pkghkbd9g5wkcwp1jxvz2-nixos-icons-2021-02-24.drv'.
error: 1 dependencies of derivation '/nix/store/xf3f5jaw4g6k15yhp8wchbdyx7zv1grq-system-path.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-noto-fonts-emoji-2.038.drv-1/source/png/32': Directory not empty
error: 1 dependencies of derivation '/nix/store/hdq2b69isxaih4wsknj01cfhqpk3g7vy-nixos-system-nixos-23.11.20231024.27e1b8e.drv' failed to build

otherwise:

warning: Git tree '/etc/nixos' is dirty
building the system configuration...
warning: Git tree '/etc/nixos' is dirty
trace: warning: rustPlatform.rust.cargo is deprecated. Use cargo instead.
trace: warning: rustPlatform.rust.rustc is deprecated. Use rustc instead.
error: builder for '/nix/store/a0jjpmyflz0pkghkbd9g5wkcwp1jxvz2-nixos-icons-2021-02-24.drv' failed with exit code 2;
       last 10 log lines:
       > no configure script, doing nothing
       > building
       > build flags: SHELL=/nix/store/lf0wpjrj8yx4gsmw2s3xfl58ixmqk8qa-bash-5.2-p15/bin/bash DESTDIR=/nix/store/43nglpyy7ippgm99x44wcnw6bzash57f-nixos-icons-2021-02-24 prefix=
       > make -C icons
       > make[1]: Entering directory '/build/source/icons'
       > convert -background none -resize 16x16 ../logo/nix-snowflake.svg 16x16/apps/nix-snowflake.png
       > convert: time limit exceeded `../logo/nix-snowflake.svg' @ fatal/cache.c/GetImagePixelCache/1707.
       > make[1]: *** [Makefile:22: 16x16/apps/nix-snowflake.png] Error 1
       > make[1]: Leaving directory '/build/source/icons'
       > make: *** [Makefile:14: icons] Error 2
       For full logs, run 'nix log /nix/store/a0jjpmyflz0pkghkbd9g5wkcwp1jxvz2-nixos-icons-2021-02-24.drv'.
error: 1 dependencies of derivation '/nix/store/xf3f5jaw4g6k15yhp8wchbdyx7zv1grq-system-path.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-noto-fonts-emoji-2.038.drv-2/source/png/32': Directory not empty
error: 1 dependencies of derivation '/nix/store/zi6hr7xmzvgqa0ccwnbljw52ar44dhx9-nixos-system-nixos-23.11.20231024.27e1b8e.drv' failed to build

Additional context

as i found a few commits referencing nixos (like the error) 7 hours ago, i then tried the commit before those, a9c0720daf7f166918002e6b2fcc272615c95ae0, which did work.
i haven't performed an actual git bisect.

Notify maintainers

@vcunat (as per my suspicion)

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.59, NixOS, 23.11 (Tapir), 23.11.20231024.a9c0720`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - channels(kiara): `"home-manager"`
 - channels(root): `"home-manager, nixos-23.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

[spiage]

I have the same issue after this commit 5655c7f for #260245

  pname = "imagemagick";
-  version = "7.1.1-19";
+  version = "7.1.1-20";

with this error log:

# nix log /nix/store/a0jjpmyflz0pkghkbd9g5wkcwp1jxvz2-nixos-icons-2021-02-24.drv^*
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/fh54a9mjy598cagglf7rzkiqkj1mkyf0-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: SHELL=/nix/store/lf0wpjrj8yx4gsmw2s3xfl58ixmqk8qa-bash-5.2-p15/bin/bash DESTDIR=/nix/store/43nglpyy7ippgm99x44wcnw6bzash57f-nixos-icons-2021-02-24 prefix=
make -C icons
make[1]: Entering directory '/build/source/icons'
convert -background none -resize 16x16 ../logo/nix-snowflake.svg 16x16/apps/nix-snowflake.png
convert: time limit exceeded `../logo/nix-snowflake.svg' @ fatal/cache.c/GetImagePixelCache/1707.
make[1]: *** [Makefile:22: 16x16/apps/nix-snowflake.png] Error 1
make[1]: Leaving directory '/build/source/icons'
make: *** [Makefile:14: icons] Error 2

My metadata

# nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.7-xanmod1, NixOS, 23.11 (Tapir), 23.11.20231024.5795319`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - nixpkgs: `/nix/store/zi1kv8q1vl5r2p1vag242zzmipmjyhnn-source`

@erictapen @dotlambda

[stigtsp]

Confirmed, convert bails instantly with the new patch in 5655c7f

$ time ~/nixpkgs/result/bin/convert -background none -resize 16x16 bar.png foo.png                              imagemagick 
convert: time limit exceeded `bar.png' @ fatal/cache.c/GetImagePixelCache/1707.

________________________________________________________
Executed in   13.75 millis    fish           external
   usr time    8.42 millis  277.00 micros    8.15 millis
   sys time    5.14 millis   52.00 micros    5.09 millis

[surfaceflinger]

looks like 7.1.1-21 has some further changes to code that caused this
ImageMagick/ImageMagick@7.1.1-20...7.1.1-21

[dotlambda]

Sorry about that, I added a commit that will prevent this from happening in the future.

[Artturin]

There seems to be an upstream issue with linux-i686:

• on i686 not work convert utility ImageMagick/ImageMagick#6820

Maybe these commits will fix the problem:

• ImageMagick/ImageMagick@3a7b915
• ImageMagick/ImageMagick@8f3c56f

See https://hydra.nixos.org/build/239665773/nixlog/1/tail

#263198 (comment)