clash-meta: rename to mihomo #271658
clash-meta: rename to mihomo #271658
Conversation
|
|
||
| meta = with lib; { | ||
| description = '' | ||
| A simple Python Pydantic model for Honkai: Star Rail parsed data from the Mihomo API |
There was a problem hiding this comment.
Should we follow the upstream here?
There was a problem hiding this comment.
I think a clear description is needed here to inform users searching on search.nixos.org about this package.
|
|
||
| meta = with lib; { | ||
| description = '' | ||
| A simple Python Pydantic model for Honkai: Star Rail parsed data from the Mihomo API |
There was a problem hiding this comment.
I think a clear description is needed here to inform users searching on search.nixos.org about this package.
oluceps
force-pushed
the
mihomo-init
branch
4 times, most recently
from
439519a
to
00939c0
Compare
|
@ofborg eval |
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
|
|
||
| buildGoModule rec { | ||
| mihomo.overrideAttrs (finalAttrs: previousAttrs: { |
There was a problem hiding this comment.
What is the difference between mihomo and clash-meta?
Or the idea is just backwards compatibility?
There was a problem hiding this comment.
There's no difference. It's just that some projects (clash-verge{,-rev}) and part of the users in the Chinese matrix room reject the renaming, so the second commit does a bit of appeasement.
See also: #290873 (comment)
There was a problem hiding this comment.
That being said, I approve the package.
Description of changes
https://github.com/MetaCubeX/mihomo/tree/Alpha
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.