Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single GNOME 3 version #29329

Closed
jtojnar opened this issue Sep 13, 2017 · 4 comments
Closed

Single GNOME 3 version #29329

jtojnar opened this issue Sep 13, 2017 · 4 comments

Comments

@jtojnar
Copy link
Member

jtojnar commented Sep 13, 2017

GNOME 3 was split into 3.10 and 3.12 in #2694. Unfortunately, we barely have the resources to update a single version of GNOME. Maintaining multiple versions just does not make sense.

Renaming pkgs/desktops/gnome-3/3.24 to pkgs/desktops/gnome-3 would also make viewing history on GitHub easier in the future.

cc @teh

@teh
Copy link
Contributor

teh commented Sep 13, 2017

I'm in favour of this. Even with git diff --find-copies-harder it was pretty hard to follow what was going on when doing the update.

@jtojnar what steps do you think are required? I can think of:

  1. A single rename commit (no edits other than imports).
  2. Adjust ./maintainers/scripts/gnome.sh as required.

@jtojnar
Copy link
Member Author

jtojnar commented Sep 13, 2017

  1. Remove environment.gnome3.packageSet.
  2. Remove gnome3_24 from pkgs/top-level/all-packages.nix

@jtojnar
Copy link
Member Author

jtojnar commented Sep 13, 2017

I am currently updating to GNOME 3.26 and want to decide this beforehand.

@vcunat
Copy link
Member

vcunat commented Sep 13, 2017

I agree it's better to have one set of files updated in-place. If desired in future, an older branch could be created as copy of some past version of those files, perhaps updated a bit later. It's just easier w.r.t. version control.

@jtojnar jtojnar mentioned this issue Sep 14, 2017
71 tasks
jtojnar added a commit to jtojnar/nixpkgs that referenced this issue Sep 20, 2017
GNOME 3 was split into 3.10 and 3.12 in NixOS#2694. Unfortunately, we barely have the resources
to update a single version of GNOME. Maintaining multiple versions just does not make sense.
Additionally, it makes viewing history using most Git tools bothersome.

This commit renames `pkgs/desktops/gnome-3/3.24` to `pkgs/desktops/gnome-3`, removes
the config variable for choosing packageset (`environment.gnome3.packageSet`), updates
the hint in maintainer script, and removes the `gnome3_24` derivation from `all-packages.nix`.

Closes: NixOS#29329
zimbatm pushed a commit that referenced this issue Sep 24, 2017
* gnome3: only maintain single GNOME 3 package set

GNOME 3 was split into 3.10 and 3.12 in #2694. Unfortunately, we barely have the resources
to update a single version of GNOME. Maintaining multiple versions just does not make sense.
Additionally, it makes viewing history using most Git tools bothersome.

This commit renames `pkgs/desktops/gnome-3/3.24` to `pkgs/desktops/gnome-3`, removes
the config variable for choosing packageset (`environment.gnome3.packageSet`), updates
the hint in maintainer script, and removes the `gnome3_24` derivation from `all-packages.nix`.

Closes: #29329

* maintainers/scripts/gnome: Use fixed GNOME 3 directory

Since we now allow only a single GNOME 3 package set, specifying
the working directory is not necessary.

This commit sets the directory to `pkgs/desktops/gnome-3`.
zimbatm pushed a commit that referenced this issue Sep 24, 2017
* gnome3: only maintain single GNOME 3 package set

GNOME 3 was split into 3.10 and 3.12 in #2694. Unfortunately, we barely have the resources
to update a single version of GNOME. Maintaining multiple versions just does not make sense.
Additionally, it makes viewing history using most Git tools bothersome.

This commit renames `pkgs/desktops/gnome-3/3.24` to `pkgs/desktops/gnome-3`, removes
the config variable for choosing packageset (`environment.gnome3.packageSet`), updates
the hint in maintainer script, and removes the `gnome3_24` derivation from `all-packages.nix`.

Closes: #29329

* maintainers/scripts/gnome: Use fixed GNOME 3 directory

Since we now allow only a single GNOME 3 package set, specifying
the working directory is not necessary.

This commit sets the directory to `pkgs/desktops/gnome-3`.

(cherry picked from commit 69698ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants