Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsevm: project was renamed to hevm #29659

Merged
merged 2 commits into from
Sep 28, 2017
Merged

hsevm: project was renamed to hevm #29659

merged 2 commits into from
Sep 28, 2017

Conversation

mbrock
Copy link
Contributor

@mbrock mbrock commented Sep 22, 2017

Motivation for this change

This also upgrades the package from v0.6.4 to v0.8.5.

The project dapp which depends on hsevm was also updated to use the
new name, so I have also upgraded that package from version v0.5.3 to
v0.5.7.

I also added a dontCheck to a Hackage dependency because its test
suite depends on Git and runs a bunch of Git repository manipulations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This also upgrades the hsevm package from v0.6.4 to v0.8.5.

The project `dapp` which depends on hsevm was also updated to use the
new name, so I have also upgraded that package from version v0.5.3 to
v0.5.7.

I also added a `dontCheck` to a Hackage dependency because its test
suite depends on Git and runs a bunch of Git repository manipulations.
@mbrock mbrock requested a review from peti as a code owner September 22, 2017 05:21
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We just need an updated version of the PR that resolves the merge conflicts, then it's good to go.

@mbrock
Copy link
Contributor Author

mbrock commented Sep 28, 2017

Thanks! I tried using the GitHub conflict resolution tool for the first time and it seems to have worked fine.

@peti peti merged commit 9271ca7 into NixOS:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants