Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: hash mismatch in qemu-8.2.3 #311497

Closed
jcumming opened this issue May 13, 2024 · 5 comments · Fixed by #311873
Closed

Build failure: hash mismatch in qemu-8.2.3 #311497

jcumming opened this issue May 13, 2024 · 5 comments · Fixed by #311873
Labels
0.kind: build failure A package fails to build

Comments

@jcumming
Copy link
Contributor

$ nix-prefetch-url https://download.qemu.org/qemu-8.2.3.tar.xz 
path is '/nix/store/hv1fyagi0acym5xlws4gjmj54qz4nvl3-qemu-8.2.3.tar.xz'
0r4raqm2rcaswivgp0ryl8r9m0pns5mqgi01fqqmb540csrpyx6w
$ nix hash to-sri --type sha256 0r4raqm2rcaswivgp0ryl8r9m0pns5mqgi01fqqmb540csrpyx6w
sha256-3HR/s2aAlFUxdgHEh2vR9oKaMqI+g/t25FqxLCpWmWQ=

The hash in nixpkgs/master right now is:

  version = "8.2.3";

  src = fetchurl {
    url = "https://download.qemu.org/qemu-${finalAttrs.version}.tar.xz";
    hash = "sha256-d1sRjKpjZiCnr0saFWRFoaKA9a1Ss7y7F/jilkhB21g=";
  };

I had both tarballs kicking around, so I checked the differences:

diff -rc good/qemu-8.2.3/roms/seabios/.version sus/qemu-8.2.3/roms/seabios/.version
*** good/qemu-8.2.3/roms/seabios/.version       2024-04-24 09:09:59.000000000 -0700
--- sus/qemu-8.2.3/roms/seabios/.version        2024-04-24 13:15:10.000000000 -0700
***************
*** 1 ****
! rel-1.16.3-0-ga6ed6b70
--- 1 ----
! rel-1.16.3-0-ga6ed6b7
Only in good/qemu-8.2.3/subprojects: dtc
@jcumming jcumming added the 0.kind: build failure A package fails to build label May 13, 2024
@jcumming
Copy link
Contributor Author

@Misterio77

A tarball with a hash matching what is in master is at https://download.qemu.org/old/qemu-8.2.3.tar.xz

seems like some trouble with the release.

@Misterio77
Copy link
Member

Misterio77 commented May 14, 2024

That's... super weird. download.qemu.org says the tarballs last modified date was April 25th (before I even opened the PR):

qemu-8.2.3-reupload.tar.bz2                        06-May-2024 13:59           156774533
qemu-8.2.3-reupload.tar.bz2.sig                    06-May-2024 13:59                 310
qemu-8.2.3-reupload.tar.xz                         06-May-2024 13:59           129917944
qemu-8.2.3-reupload.tar.xz.sig                     06-May-2024 14:00                 310
qemu-8.2.3.tar.bz2                                 25-Apr-2024 02:18           156774533
qemu-8.2.3.tar.bz2.sig                             25-Apr-2024 02:18                 310
qemu-8.2.3.tar.xz                                  25-Apr-2024 02:18           129917944
qemu-8.2.3.tar.xz.sig                              25-Apr-2024 02:18                 310

Maybe we should use the gitlab tarball instead?

@Misterio77
Copy link
Member

Misterio77 commented May 14, 2024

Okay, found some context: https://mail.gnu.org/archive/html/qemu-stable/2024-05/msg00025.html. This took a while to break due to aggressive CDN caching, it seems.

@jcumming
Copy link
Contributor Author

Thanks!

Not sure this is worth fixing or just wait for #298097 to land.

@alyssais
Copy link
Member

It's going to be a while before we can get 9.0.0 due to the release freeze, so this is definitely worth fixing now.

alyssais added a commit to alyssais/nixpkgs that referenced this issue May 15, 2024
New release was created in part to work around issues with CDN caching
of multiple versions of the 8.2.3 tarball.

Closes: NixOS#311497
@alyssais alyssais mentioned this issue May 15, 2024
13 tasks
alyssais added a commit that referenced this issue May 15, 2024
New release was created in part to work around issues with CDN caching
of multiple versions of the 8.2.3 tarball.

Closes: #311497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants