Linux 4.14 breakage tracking issue #31640

orivej · 2017-11-14T00:42:22Z

4.14 is going to be the next LTS kernel - http://kroah.com/log/blog/2017/10/16/linux-kernel-community-enforcement-statement/

NeQuissimus · 2017-11-14T01:36:28Z

I need help in #31037, that should take care of VirtualBox

NeQuissimus · 2017-11-14T03:33:58Z

I have been trying to get amdgpu-pro fixed for a little while now but I think it does require an update from AMD's side for kernel 4.14.x

Or it's because I don't know make too well, the build errors out like so:

  CC [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/kfd_crat.o
  CC [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/kfd_rdma.o
  CC [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/kfd_peerdirect.o
  CC [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/kfd_ipc.o
  CC [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/kfd_debugfs.o
  LD [M]  /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkfd/amdkfd.o
make[2]: *** [/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/Makefile:1503: _module_/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261] Error 2
make[1]: *** [Makefile:146: sub-make] Error 2
make: *** [Makefile:24: __sub-make] Error 2
make: Leaving directory '/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/build'
note: keeping build directory ‘/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-1’
builder for ‘/nix/store/z5q0c0q0gqd02skgxh94wgiccpx3jsc8-amdgpu-pro-17.40-4.14.drv’ failed with exit code 2
error: build of ‘/nix/store/z5q0c0q0gqd02skgxh94wgiccpx3jsc8-amdgpu-pro-17.40-4.14.drv’ failed

orivej · 2017-11-14T03:42:16Z

Re. make you have posted Error 2, a secondary error. The actual cause of the failure is Error 1 somewhere above.

MP2E · 2017-11-14T03:45:12Z

Working on mwprocapture now, it compiles on my local tree but doesn't work yet, as vfs_write and vfs_read are no longer exported

Also, with PR #31148 nvidia_x11 builds and works successfully with kernel 4.14.0, on my end

NeQuissimus · 2017-11-14T03:49:24Z

@orivej Ah, I had to scroll WAY up :)
It looks bad (to the untrained eye :D)...

/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:271:29: error: incompatible type for argument 7 of 'drm_universal_plane_init'
      formats, format_count, type, name);
                             ^~~~
In file included from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_crtc.h:45:0,
                 from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drmP.h:69,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:6,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:
/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_plane.h:548:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type'
 int drm_universal_plane_init(struct drm_device *dev,
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:0:
/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:271:35: error: incompatible type for argument 8 of 'drm_universal_plane_init'
      formats, format_count, type, name);
                                   ^~~~
In file included from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_crtc.h:45:0,
                 from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drmP.h:69,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:6,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:
/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_plane.h:548:5: note: expected 'enum drm_plane_type' but argument is of type 'const char *'
 int drm_universal_plane_init(struct drm_device *dev,
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:0:
/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:270:10: error: too few arguments to function 'drm_universal_plane_init'
   return drm_universal_plane_init(dev, plane, possible_crtcs, funcs,
          ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_crtc.h:45:0,
                 from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drmP.h:69,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:6,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:
/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_plane.h:548:5: note: declared here
 int drm_universal_plane_init(struct drm_device *dev,
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:0:
/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h: In function 'kcl_drm_calc_vbltimestamp_from_scanoutpos':
/tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:332:9: error: too many arguments to function 'drm_calc_vbltimestamp_from_scanoutpos'
  return drm_calc_vbltimestamp_from_scanoutpos(dev, pipe, max_error, vblank_time,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drmP.h:83:0,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/include/kcl/kcl_drm.h:6,
                 from /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.c:1:
/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/include/drm/drm_vblank.h:173:6: note: declared here
 bool drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/scripts/Makefile.build:314: /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl/kcl_drm.o] Error 1
make[3]: *** [/nix/store/prk1nwg5s1619jbrpp67v5jr3xpv7347-linux-4.14-dev/lib/modules/4.14.0/source/scripts/Makefile.build:573: /tmp/nix-build-amdgpu-pro-17.40-4.14.drv-0/amdgpu-pro-17.40-492261/root/usr/src/amdgpu-17.40-492261/amd/amdkcl] Error 2

All this "too many arguments", "too few arguments" sound like an API mismatch to me..

NeQuissimus · 2017-11-14T03:50:51Z

Maybe we should just undo declaring 4.14 the new default for the moment, so we unblock the channel?!

It's pretty late where I am, somebody please do so? :) thx!

MP2E · 2017-11-14T03:56:04Z

Fixed mwprocapture as of ce8dea6 !

(Linking fully works, and I recorded video/did a quick test stream)

@NeQuissimus no problem, I will set the attribute back to version 4.9 and it can be set back when the dust settles a bit!

orivej · 2017-11-14T04:03:47Z

@MP2E This may or may not be quite correct, see what ZFS developers did: https://github.com/zfsonlinux/spl/pull/666/files#diff-fc21f15a0f248a8ac8af4d3a06d86a89

partially reverts bfe9c92 by author's request, since many modules are currently broken. 4.14 will be the default kernel when the dust settles track github issue #31640

orivej · 2017-11-14T04:07:22Z

@NeQuissimus I think so, let's fix this issue and retry.

MP2E · 2017-11-14T04:22:59Z

Thanks for the pointer, after looking through the source a lot more carefully, it seems that it works as-is, but I noticed that one of the types was wrong, so I fixed it and updated the patch

NeQuissimus · 2017-11-15T22:19:46Z

Virtualbox will work with 4.14 once 5.2.1 is out: https://www.virtualbox.org/ticket/17080

Baughn · 2017-11-15T23:27:42Z

Worth noting that Linux 4.9 doesn't work properly with Threadripper CPUs, specifically throwing a lot of bus errors due to a problematic ASPM implementation.

4.13.11 seems to be fine. Maybe we could use that?

adisbladis · 2017-11-16T04:36:09Z

zfsUnstable resolved in #31729

vcunat · 2017-11-16T21:10:46Z

@Baughn: 4.13 is going away very soon. On the other hand, GKG will be maintaining 4.14 for years.

Baughn · 2017-11-23T18:40:38Z

@vcunat Yeah, I didn't mean permanently. :)

For the moment I've pinned my workstation to 4.13, but I'll be tracking the latest kernel for a while anyway; there are hardware features that won't be supported until at least 4.15, such as the CPU temperature sensors.

I realize my use case isn't common. Luckily it's a single-line fix for me. :P

aszlig · 2017-11-24T22:11:58Z

VirtualBox done in e5c24ab.

@NeQuissimus

Upstream changes without issue IDs: * User interface: various improvements for high resolution screens * User interface: added functionality to duplicate optical and floppy images * User interface: various improvements for the virtual media manager * VMM: fixed emulation so that Plan 9 guests can start once more (5.1.0 regression) * Storage: fixed regression breaking iSCSI * Audio: added HDA support for more exotic guests (e.g. Haiku) * Serial: fixed hanging I/O when using named pipes on Windows (5.2.0 regression) * Serial: fixed broken communication with certain devices on Linux hosts * USB/OHCI: improved behavior so that the controller state after a VM reset is closer to the initial state after VM start * EFI: fixed HFS+ driver which in rare cases failed to access most files on a volume * Shared clipboard: fixed hang with OS X host and Linux guest * Linux hosts: fixed kernel module compilation and start failures with Linux kernel 4.14 * X11 hosts: better handle WM_CLASS setting * Linux guests: fixed kernel module compilation and other problems with Linux kernel 4.14 * Linux guests: fixed various 5.2.0 regressions * Bridged networking: fixed duplicate EtherType in VLAN/priority tags on Linux (5.2.0 regression) The full changelog including issue IDs can be found at: https://www.virtualbox.org/wiki/Changelog Aside from just bumping the version number I also had to strip 3 levels of the paths included in the guest-additions patches, because the version was hardcoded in there and the patches still apply as-is. I've re-added the stripped path using patchFlags and the -d option of the patch utility. Tested this by running all of the tests in the "virtualbox" NixOS VM test module, here is the URL to the finished evaluation on my Hydra: https://headcounter.org/hydra/eval/380191 Signed-off-by: aszlig <aszlig@nix.build> Cc: @NeQuissimus, @orivej, @etu, @vcunat Issue: #31640 Issue: #31037

This reverts commit b39ab30. There are some show stopper issues in the 4.14 kernel that are still not resolved. #31640

/cc #31640. (cherry picked from commit 6aa3f54)

/cc #31640. (cherry picked from commit b934716)

This reverts commit b39ab30. There are some show stopper issues in the 4.14 kernel that are still not resolved. #31640 (cherry picked from commit 74857c9)

This change is done for completness in regards to [1] since we already support a newer "stable" version. nvidia_x11_beta now compiles on both 4.14 and 4.15. [1] NixOS#31640

vcunat · 2018-02-13T11:45:06Z

Do you think anything is blocking update of default to 4.14 (now)? For amdgpu-pro we can add an assertion advising users to switch to 4.9 manually. Nixpkgs 18.03 is to be forked in about two weeks.

NeQuissimus · 2018-02-13T13:22:56Z

I've been running 4.14.x and 4.15.x for quite a while now, I have had no issues. (albeit Intel GPU)

vcunat · 2018-02-13T13:34:26Z

For the record, during the last two weeks I've been using 4.14 only. It was mostly on a pure Intel system (Skylake-S) without any problems, and also on Ryzen + Nvidia with just those Ryzen bugs (probably).

fpletz · 2018-02-13T16:14:12Z

We have not experienced problems with current 4.14 kernels on servers, VMs and laptops so far. As 4.14 also has long-term support, I also think we should default to that version for 18.03.

/cc #31640.

vcunat · 2018-02-22T00:44:40Z

Yes, we keep all kernels supported upstream, i.e. six longterm branches now from which two are to be dropped soon. 4.14 is default in master now.

adisbladis · 2018-02-22T01:44:16Z

It should be ok to change default to 4.14 as long as 4.9 and 4.4 are still around

4.14 is supported until January 2019 and 4.4 until February 2022 so I see no reason we should drop these. :)

Ekleog · 2018-10-10T00:27:44Z

(triage) 4.14 is currently the default on 18.03, so I assume it has been for quite a while. If no issue has been reported… maybe this issue should be closed?

fpletz · 2018-10-11T07:44:48Z

Yeah, we can close this. Just checked the remaining issues: the amdgpu PR was merged and the Intel 3D issues were fixed upstream.

vcunat · 2018-10-11T09:02:28Z

amdgpu-pro bump was merged. It doesn't build now with 4.14, but that's probably just a minor libelf issue. On the whole it seems like it has few users if any.

vcunat · 2018-10-11T09:17:02Z

Hmm, no, the obvious fix isn't enough:

--- a/pkgs/os-specific/linux/amdgpu-pro/default.nix
+++ b/pkgs/os-specific/linux/amdgpu-pro/default.nix
@@ -164,7 +164,7 @@ in stdenv.mkDerivation rec {
     done
   '';
 
-  buildInputs = [
+  nativeBuildInputs = kernel.moduleBuildDependencies ++ [
     patchelf
     perl
   ];

It fixes the ORC problem but fails later on some incompatibilities – it's apparently too new kernel (or libdrm or something) for that driver version.

orivej referenced this issue Nov 14, 2017

linux_latest: 4.9 -> 4.14

bfe9c92

4.14 is going to be the next LTS kernel - http://kroah.com/log/blog/2017/10/16/linux-kernel-community-enforcement-statement/

NeQuissimus added 1.severity: blocker 6.topic: kernel 6.topic: nixos 9.needs: community feedback 9.needs: package (update) labels Nov 14, 2017

NeQuissimus mentioned this issue Nov 14, 2017

[WIP] amdgpu-pro: 17.10 -> 17.40 #31644

Closed

8 tasks

MP2E pushed a commit that referenced this issue Nov 14, 2017

linuxPackages: revert default linux kernel to 4.9

eb85eb5

partially reverts bfe9c92 by author's request, since many modules are currently broken. 4.14 will be the default kernel when the dust settles track github issue #31640

fpletz added this to the 18.03 milestone Nov 14, 2017

Mic92 mentioned this issue Nov 15, 2017

linuxPackages.openafs-client: fixes for 4.14 #31694

Merged

8 tasks

Mic92 mentioned this issue Nov 19, 2017

VBox fails to build on current nixos-unstable-small #31792

Closed

etu mentioned this issue Nov 20, 2017

virtualbox: 5.1.26 -> 5.2.0 #31037

Merged

8 tasks

adisbladis added a commit that referenced this issue Dec 4, 2017

Revert "linux_4_13: Remove, no longer supported."

74857c9

This reverts commit b39ab30. There are some show stopper issues in the 4.14 kernel that are still not resolved. #31640

yellowgh0st mentioned this issue Dec 5, 2017

nvidia-x11 384.90 no longer compiles with linuxPackages_latest 4.14.3 on NixOS 17.09 #32330

Closed

vcunat added a commit that referenced this issue Dec 5, 2017

nvidia_x11_legacy340: patch to support kernel 4.14

a8b76c4

/cc #31640. (cherry picked from commit 6aa3f54)

vcunat added a commit that referenced this issue Dec 5, 2017

nvidia_x11_legacy304: fix build with kernel 4.14

120ebc0

/cc #31640. (cherry picked from commit b934716)

vcunat pushed a commit that referenced this issue Dec 6, 2017

Revert "linux_4_13: Remove, no longer supported."

42a7a08

This reverts commit b39ab30. There are some show stopper issues in the 4.14 kernel that are still not resolved. #31640 (cherry picked from commit 74857c9)

clefru mentioned this issue Dec 13, 2017

zfs/spl bump to 0.7.4 to fix incompatibility with 4.14 #32634

Merged

8 tasks

andir added a commit to andir/nixpkgs that referenced this issue Feb 8, 2018

nvidia_x11_beta: 381.22 -> 390.12

e7be80d

This change is done for completness in regards to [1] since we already support a newer "stable" version. nvidia_x11_beta now compiles on both 4.14 and 4.15. [1] NixOS#31640

fpletz self-assigned this Feb 13, 2018

vcunat added 9.needs: changelog and removed 9.needs: community feedback 9.needs: package (update) labels Feb 21, 2018

vcunat added a commit that referenced this issue Feb 21, 2018

linuxPackages: 4.9 -> 4.14

e2398e4

/cc #31640.

fpletz removed their assignment Feb 23, 2018

matthewbauer modified the milestones: 18.03, 18.09 Apr 17, 2018

fpletz closed this as completed Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux 4.14 breakage tracking issue #31640

Linux 4.14 breakage tracking issue #31640

orivej commented Nov 14, 2017 •

edited by fpletz

Loading

NeQuissimus commented Nov 14, 2017

NeQuissimus commented Nov 14, 2017

orivej commented Nov 14, 2017

MP2E commented Nov 14, 2017 •

edited

Loading

NeQuissimus commented Nov 14, 2017 •

edited

Loading

NeQuissimus commented Nov 14, 2017 •

edited

Loading

MP2E commented Nov 14, 2017 •

edited

Loading

orivej commented Nov 14, 2017

orivej commented Nov 14, 2017

MP2E commented Nov 14, 2017

NeQuissimus commented Nov 15, 2017

Baughn commented Nov 15, 2017

adisbladis commented Nov 16, 2017

vcunat commented Nov 16, 2017

Baughn commented Nov 23, 2017 •

edited

Loading

aszlig commented Nov 24, 2017

vcunat commented Feb 13, 2018

NeQuissimus commented Feb 13, 2018

vcunat commented Feb 13, 2018

fpletz commented Feb 13, 2018

vcunat commented Feb 22, 2018

adisbladis commented Feb 22, 2018 •

edited

Loading

Ekleog commented Oct 10, 2018

fpletz commented Oct 11, 2018

vcunat commented Oct 11, 2018

vcunat commented Oct 11, 2018 •

edited

Loading

Linux 4.14 breakage tracking issue #31640

Linux 4.14 breakage tracking issue #31640

Comments

orivej commented Nov 14, 2017 • edited by fpletz Loading

NeQuissimus commented Nov 14, 2017

NeQuissimus commented Nov 14, 2017

orivej commented Nov 14, 2017

MP2E commented Nov 14, 2017 • edited Loading

NeQuissimus commented Nov 14, 2017 • edited Loading

NeQuissimus commented Nov 14, 2017 • edited Loading

MP2E commented Nov 14, 2017 • edited Loading

orivej commented Nov 14, 2017

orivej commented Nov 14, 2017

MP2E commented Nov 14, 2017

NeQuissimus commented Nov 15, 2017

Baughn commented Nov 15, 2017

adisbladis commented Nov 16, 2017

vcunat commented Nov 16, 2017

Baughn commented Nov 23, 2017 • edited Loading

aszlig commented Nov 24, 2017

vcunat commented Feb 13, 2018

NeQuissimus commented Feb 13, 2018

vcunat commented Feb 13, 2018

fpletz commented Feb 13, 2018

vcunat commented Feb 22, 2018

adisbladis commented Feb 22, 2018 • edited Loading

Ekleog commented Oct 10, 2018

fpletz commented Oct 11, 2018

vcunat commented Oct 11, 2018

vcunat commented Oct 11, 2018 • edited Loading

orivej commented Nov 14, 2017 •

edited by fpletz

Loading

MP2E commented Nov 14, 2017 •

edited

Loading

NeQuissimus commented Nov 14, 2017 •

edited

Loading

NeQuissimus commented Nov 14, 2017 •

edited

Loading

MP2E commented Nov 14, 2017 •

edited

Loading

Baughn commented Nov 23, 2017 •

edited

Loading

adisbladis commented Feb 22, 2018 •

edited

Loading

vcunat commented Oct 11, 2018 •

edited

Loading