Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mathutils: init at 3.3.0 #320946

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

autra
Copy link
Contributor

@autra autra commented Jun 19, 2024

Description of changes

This PR packages mathutils for nix. The motivation is mainly for #312380 and #312381 because mathutils is now a dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

@autra greetings !

can you split into two commits

The main motivation is to fix ifcopenshell packages, because mathutils
is now a dependency.
@kirillrdy
Copy link
Member

@ofborg build python3Packages.mathutils

@autra can you update PR title to python3Packages.mathutils: init at 3.3.0

@autra autra changed the title python: package mathutils python3Packages.mathutils: init at 3.3.0 Jun 20, 2024
@autra
Copy link
Contributor Author

autra commented Jun 20, 2024

@kirillrdy done! Thanks for educating me :-)

@kirillrdy
Copy link
Member

thank you for PR and welcome to nixpkgs !

@kirillrdy kirillrdy merged commit b2d0bc1 into NixOS:master Jun 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants