Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recoll-1.18.1 #439

Merged
merged 2 commits into from
Apr 3, 2013
Merged

recoll-1.18.1 #439

merged 2 commits into from
Apr 3, 2013

Conversation

jcumming
Copy link
Contributor

@jcumming jcumming commented Apr 2, 2013

Recoll is a handy xapian based desktop search engine.

@jcumming
Copy link
Contributor Author

jcumming commented Apr 2, 2013

More filter hacking pending..

@vcunat
Copy link
Member

vcunat commented Apr 3, 2013

Looks very interesting, thanks.

vcunat added a commit that referenced this pull request Apr 3, 2013
@vcunat vcunat merged commit a89ca06 into NixOS:master Apr 3, 2013
@peti
Copy link
Member

peti commented Apr 3, 2013

I think this patch broke the nixpkgs tarbal: http://hydra.nixos.org/build/4635913

@vcunat
Copy link
Member

vcunat commented Apr 3, 2013

@peti: that's very stange, as recoll builds on my machine on the same platform and I see no reason why some of the attributes should evaluate to null.

@vcunat
Copy link
Member

vcunat commented Apr 3, 2013

Ah, no, I was reading bad. The problem is on darwin, where libiconvOrLibc is null.

@jcumming
Copy link
Contributor Author

jcumming commented Apr 3, 2013

Oh Bother.

I should have closed this pull request. I wasn't happy with where this approach was going.

Indexing/lookup works, and some of the filters work, but most don't.

I reworked it into something better by pushing a lot of the filter hacking upstream: https://bitbucket.org/medoc/recoll/pull-request/2/use-autoconf-to-find-helper-programs-for .

I'll submit a new pull request when I'm happy with it.

--Jack

P.S. what is the best way to get ahold of iconv?

@vcunat
Copy link
Member

vcunat commented Apr 3, 2013

I tried to disable this on darwin by an assert, which makes the tarball job pass that phase checking pkgs/top-level/all-packages.nix on powerpc-linux, but then while checking eval-release.nix it eats more then 3.5 GB RAM at which point I killed it. Is it normal that the job needs so much memory?

@jcumming: I've got experiences in this. I thought the iconv attribute should be used everywhere where glibc doesn't contain it. If that's true, then the attribute you used seems broken on darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants