nixos/tomcat: regression in master: type specification for services.tomcat.virtualHosts is wrong

[pvgoran]

Issue description

Commit 472f16d introduced type specification for services.tomcat.virtualHosts (which was absent before), but this specification is wrong.

Steps to reproduce

From within release-18.03, import the tomcat module from the master branch, and create a minimal Tomcat configuration that uses virtualHosts:

  imports = [
    /home/paul/nixpkgs-unstable/nixos/modules/services/web-servers/tomcat.nix
  ];
  disabledModules = [ "services/web-servers/tomcat.nix" ];

  services.tomcat.enable = true;
  services.tomcat.virtualHosts = [
    { name = "nixos";
      webapps = [ /deploy/testhost ];
    }
  ];

And see it fails:

paul@nixos> sudo nixos-rebuild switch
building Nix...
building the system configuration...
error: The option `services.tomcat.virtualHosts.[definition 1-entry 1].webapps' defined in `/etc/nixos/play.nix' does not exist.

When using the native module from release-18.03, everything works.

Technical details

• system: "x86_64-linux"
• host os: Linux 4.14.59, NixOS, 18.03.133004.a1299c9951b (Impala)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.0.4
• channels(paul): ""
• channels(root): "nixos-18.03.133004.a1299c9951b"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

[pvgoran]

It's only semi-related, but why on earth is the type of services.tomcat.webapps a list of packages, and not just a list of paths or strings?? It severely limits the configuration options for no apparent gain.

[pvgoran]

For the record, #44370 was an issue about overly restrictive type of services.tomcat.webapps.