Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-tsx: init at 2017-03-16 #46728

Closed
wants to merge 2 commits into from

Conversation

samdroid-apps
Copy link
Contributor

@samdroid-apps samdroid-apps commented Sep 16, 2018

Motivation for this change

Add a plugin for vim that does highlighting for typescript jsx.

example usage:

let
  myVim = pkgs.vim_configurable.customize {                                   
    name = "vim";                                                      
    vimrcConfig.vam.pluginDictionaries = [                                           
      { name = "vim-tsx"; }
    ];
  };
in
...

Then you can view a tsx file. This is an example file you could download to test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: vim 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 labels Sep 16, 2018
@@ -375,17 +375,6 @@
};
};

deoplete-jedi = buildVimPluginFrom2Nix {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. This should have been not removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase your code to the latest master and try to regnerate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a bug in the vim updater. I've been trying to add some vim packages and ./updater.py removed some untouched plugins (supertab for instance) from generated.nix which makes the updater fails teh second time. Maybe it should generate a diff and ask for confimaton before overwriting the generated.nix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samdroid-apps
Copy link
Contributor Author

Oh OK so I've found the root issue would have been that my system didn't have nix-prefetch-git. What package is meant to provide that?

@samdroid-apps
Copy link
Contributor Author

So the required nixpkgs.nix-prefetch-git package wasn't included in the nix shell command. I've added that and force pushed.

I think this fixes the issues and can now be merged 😄

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2018

oh, now I already have added nix-prefetch-git.

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2018

Cherry-picked in 0e1f3ef

@Mic92 Mic92 closed this Sep 20, 2018
Mic92 pushed a commit that referenced this pull request Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants