glfw: hardwire path to libGL.so.1

[avnik]

Motivation for this change

glfw use direct path to dlopen'ing libGL, so let hardwire path to libGL.so.1 (aka libglvnd).
Fix #46423. Possible that glfw-2.x package need a similiar fix.

/cc @samueldr (possible this commit is candidate to release-18.09 branch)

PS I also update epoxy as part of work on #46423, which is subject of own PR

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[avnik]

Looks, like it need to be fixed once more, and apply libGL hardwiring on non-darwin only.

[avnik]

Well, disregarding my last comment, it already have related !isDarwin, but invalidate some darwin packages anyway, look like ofBorg issue. /cc @grahamc

[samueldr]

Hi!

lib.optional, when false, will still change the environment when adding a new attribute. That is because lib.optionla returns an empty list. This sets preConfigure to [], which in turn, in bash, will be preConfigure=. The glfw derivation did change for macOS, though largely a no-op.

---

As far as backporting to 18.09, I'm all for, assuming this is the right fix for the issue. Ping me for the backport after someone else with the OpenGL infrastructure knowledge has approved (and possibly merged) this PR. I'm not sure I know how to verify the validity of the change.

[Mic92]

maybe @lheckemann

[dtzWill]

Ping? Ran into it testing the zig 0.3 update (although it happens regardless of zig version I believe).

[andrewrk]

Who or what is this blocking on?

[andrewrk]

I confirm this fixes #46423 for me.

[Mic92]

backport: 894a999

[andrewrk]

Thanks!