Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcheckpass: it is in kscreenlocker, not plasma-workspace #47838

Merged
merged 1 commit into from
Oct 4, 2018
Merged

kcheckpass: it is in kscreenlocker, not plasma-workspace #47838

merged 1 commit into from
Oct 4, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

The suid wrapper for kcheckpass was referencing the wrong package.

Cc: @bkchr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 4, 2018
@peterhoeg peterhoeg mentioned this pull request Oct 4, 2018
Closed
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 4, 2018
@peterhoeg peterhoeg merged commit 6b4d336 into NixOS:master Oct 4, 2018
@peterhoeg peterhoeg deleted the f/plasma branch October 4, 2018 07:42
@peterhoeg peterhoeg restored the f/plasma branch October 4, 2018 11:51
@peterhoeg peterhoeg deleted the f/plasma branch October 8, 2018 01:24
@peterhoeg peterhoeg mentioned this pull request Mar 22, 2021
Closed
10 tasks
rnhmjoj referenced this pull request Jun 11, 2022
@rnhmjoj
nixos/security/wrappers: check that sources exist
7d8b303 
Add a shell script that checks if the paths of all wrapped programs
actually exist to catch mistakes. This only checks for Nix store paths,
which are always expected to exist at build time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterhoeg @bkchr @GrahamcOfBorg