Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-frameworks: 5.51 -> 5.52 #50248

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Nov 11, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner November 11, 2018 20:33
@roberth roberth added the 8.has: package (update) This PR updates a package to a newer version label Nov 13, 2018
@ttuegel ttuegel merged commit f09b1ff into NixOS:master Nov 18, 2018
@ttuegel
Copy link
Member

ttuegel commented Nov 18, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants