-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox{-esr,-bin,}: update to 64.0, 60.4.0esr #51863
Conversation
Hmm, FF 64 fails to link libxul on my machine (no interesting log unfortunately):
I used the other two for more than dozen minutes each, so I expect they'll be OK and pushed them. |
That is interesting. Are you maybe running out of (disk) space? I am running a FFX64 on a two of my machines. |
It's 8 GiB tmpfs, otherwise empty – do you think it likely? I haven't watched it. (And the error message could be clearer in any case :-/) |
I am very sure that is likely. I have run in space limitations for the past few versions. Usually remounting the tmpfs there to around ~10GB fixed it. Here is the log from my successful build this morning - maybe you can spot a difference. |
@vcunat Did increasing the scratch space solve the error for you? I did rebuild both of the packages on another host just fine. |
Confirmed. All in master now. -bin in 18.09 as well. I expect to do porting of non-bin this evening, but anyone can be quicker than me ;-) |
Would you agree we should sync expression in release-18.09 from master in terms of using the identifier |
I totally agree.. I hit that issue more then once already. The changes made
in master look reasonable and there is not reason to not include them.
…On Thu, 13 Dec 2018, 09:07 Vladimír Čunát, ***@***.***> wrote:
Would you agree we should sync expression in release-18.09 from master in
terms of using the identifier ffversion vs. version? I think the
difference unnecessarily complicates cherry-picks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#51863 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAm_dIoeeQJU0mq0omyG2-N7dzP0acSCks5u4gqtgaJpZM4ZNDah>
.
|
Will 64.0 also land in release-18.09, or is stable bound to use the esr releases only? |
We do backport all firefox updates. I haven't managed to do it yet (neither has anyone else apparently). |
I've started with syncing both expressions on a new branch: https://github.com/NixOS/nixpkgs/tree/release-18.09-firefox64 Gave up for now because I ran into this weird error:
|
Yes, I'm getting the same. No ideas so far. |
Oh, that machine was giving me the same error also for the newly merged backport, but another machine managed to succeed. I don't have that failing machine under control, so I don't really know, but perhaps it's a bad error message for some kind of resource exhaustion. |
See NixOS#51863. (cherry picked from commit 783dc61)
See NixOS#51863. (cherry picked from commit ccd1600)
Motivation for this change
Bump to the latest versions of firefox.
The version 64.0 release notes will appear here: https://www.mozilla.org/en-US/firefox/64.0/releasenotes/
The version 60.4.0esr0 release notes will appear here: https://www.mozilla.org/en-US/firefox/60.4.0/releasenotes/
This should be backported to 18.09. It depends on #51365 being ported first. The backport is trivial since most of the required dependencies have already been updated. The only catch is the change of
version
toffversion
that exists in master.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)