Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk{2,3}-x11 fails to build on Darwin #54424

Closed
smaret opened this issue Jan 21, 2019 · 6 comments
Closed

gtk{2,3}-x11 fails to build on Darwin #54424

smaret opened this issue Jan 21, 2019 · 6 comments
Labels
0.kind: regression Something that worked before working no longer 6.topic: darwin Running or building packages on Darwin

Comments

@smaret
Copy link
Member

smaret commented Jan 21, 2019 •
edited
Loading

Issue description

gtk+-2.24.32 fails to build on Darwin with the following error message:

gdkapplaunchcontext-x11.c:29:10: fatal error: 'gio/gdesktopappinfo.h' file not found
#include <gio/gdesktopappinfo.h>
         ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[4]: *** [Makefile:843: gdkapplaunchcontext-x11.lo] Error 1
[...]
builder for '/nix/store/zikf8wwzs8q5rdgydkr31qjlnsgy8wnf-gtk+-2.24.32.drv' failed with exit code 2

Steps to reproduce

nix-build -A gtk2-x11

Technical details

  • system: "x86_64-darwin"
  • host os: Darwin 18.2.0, macOS 10.14.2
  • multi-user?: no
  • sandbox: no
  • version: nix-env (Nix) 2.2
  • channels(smaret): "nixos-19.03pre161883.e85c1f58680, nixpkgs-19.03pre160749.3a393eecafb"
  • nixpkgs: /nix/store/ky1klzpsz7dx098rv7j5zahnkhdlicfq-master.tar.gz
@hedning hedning added the 6.topic: darwin Running or building packages on Darwin label Jan 21, 2019
@hedning
Copy link
Contributor

hedning commented Jan 21, 2019

Probably caused by #54007. First failure happened with this diff.

@hedning
Copy link
Contributor

hedning commented Jan 21, 2019

So glib on darwin no longer provides the header. I'm guessing we should switch from gtk{2,3}-x11 to gtk{2,3} as many places as possible, hopefully that's possible now.

@hedning hedning added the 0.kind: regression Something that worked before working no longer label Jan 21, 2019
@hedning
Copy link
Contributor

hedning commented Jan 21, 2019

Some more info at #54428

@hedning hedning changed the title gtk+-2.24.32 fails to build on Darwin gtk{2,3}-x11 fails to build on Darwin Jan 21, 2019
@smaret
Copy link
Member Author

smaret commented Jan 22, 2019

It builds on staging. Is there a fix in this branch?

@jtojnar
Copy link
Member

jtojnar commented Jan 22, 2019

The issue is on master.

@smaret smaret mentioned this issue Jan 22, 2019
Merged
10 tasks
@matthewbauer
Copy link
Member

gtk{2,3}-x11 is pretty much required in lots of places without extensive patching (fatal error: 'gdk/gdkx.h' file not found)

@jtojnar jtojnar mentioned this issue Jan 26, 2019
Merged
10 tasks
gnomesysadmins pushed a commit to GNOME/gtk that referenced this issue Jan 26, 2019
@jtojnar
osx: Fix building gdk-x11
b366d6c 
Glib linked against Apple libraries does not provide <gio/gdesktopappinfo.h>
header. When building X11 GTK backend on MacOS against such Glib, it fails
because it cannot find the header. X11 backend is still required by programs
like vim or Emacs.

Let’s use the same trick gtk-launch.c uses to solve this issue.

NixOS/nixpkgs#54424
@matthewbauer matthewbauer mentioned this issue Jan 27, 2019
Closed
gnomesysadmins pushed a commit to GNOME/gtk that referenced this issue Apr 30, 2020
@jtojnar
osx: Fix building gdk-x11
1382776 
Glib linked against Apple libraries does not provide <gio/gdesktopappinfo.h>
header. When building X11 GTK backend on MacOS against such Glib, it fails
because it cannot find the header. X11 backend is still required by programs
like vim or Emacs.

Let’s use the same trick gtk-launch.c uses to solve this issue.

NixOS/nixpkgs#54424
gnomesysadmins pushed a commit to GNOME/gtk that referenced this issue May 16, 2020
@jtojnar
osx: Fix building gdk-x11
feb20b8 
Glib linked against Apple libraries does not provide <gio/gdesktopappinfo.h>
header. When building X11 GTK backend on MacOS against such Glib, it fails
because it cannot find the header. X11 backend is still required by programs
like vim or Emacs.

Let’s use the same trick gtk-launch.c uses to solve this issue.

NixOS/nixpkgs#54424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matthewbauer @hedning @smaret @jtojnar