Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.86.4 -> 0.87.1 #55383

Merged
merged 5 commits into from
Mar 3, 2019
Merged

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 7, 2019
@peterhoeg
Copy link
Member

This breaks zoneminder as camera/switch/sensor.zoneminder has moved under the zoneminder component:

error: attribute 'camera.zoneminder' missing, at /home/peter/src/active/nixpkgs_unstable/pkgs/servers/home-assistant/default.nix:82:28

So parse-requirements.py changes from camera.zoneminder to zoneminder.camera although it should be camera.zoneminder.

@dotlambda
Copy link
Member Author

How does camera.zoneminder get into your extraComponents?

@dotlambda dotlambda changed the title home-assistant: 0.86.4 -> 0.87.0 home-assistant: 0.86.4 -> 0.87.1 Feb 11, 2019
@dotlambda
Copy link
Member Author

@peterhoeg Did you check again?

@peterhoeg
Copy link
Member

I haven't tried, sorry.

@peterhoeg
Copy link
Member

@dotlambda
Copy link
Member Author

I see. Maybe parse-requirements.py will have to be rewritten.
However, the only way I can think of how your error can occur is by manually adding camera.zoneminder to extraComponents.

@dotlambda
Copy link
Member Author

@peterhoeg I found the cause of the error. Seems like it's the same as in #55958. Sorry for that.

@dotlambda
Copy link
Member Author

@peterhoeg 753f58d has made it into the nixos-18.09 channel. Could you upgrade your system and try this PR again?

@peterhoeg
Copy link
Member

Now the re-organized components are fine, but ffmpeg and unifi are broken (might be their python packages that need updating). And of course 0.88 is out...

@dotlambda
Copy link
Member Author

@netixx I think my last commit should make mqtt.sensor be picked up with your configuration.

@peterhoeg SO, would you be fine with merging this as is? I'd prefer to merge before tackling 0.88.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 27, 2019
@dotlambda
Copy link
Member Author

@peterhoeg I pushed two Python package updates that may fix ffmpeg and unifi. You're sure aiounifi, which isn't yet packaged, isn't needed for the unifi component to work at all? https://github.com/home-assistant/home-assistant/blob/0.87.1/requirements_all.txt#L136

@netixx
Copy link
Contributor

netixx commented Feb 27, 2019

It will be difficult for me to test this because my setup is a little bit complicated, but you'd just have to define platform=mqtt for a sensor to test it.

By the way I had an import error for aiounifi using unify device_tracker platform, along with pyunifi- so I can sort of confirm both are needed!

@dotlambda
Copy link
Member Author

It will be difficult for me to test this because my setup is a little bit complicated, but you'd just have to define platform=mqtt for a sensor to test it.

I tested it with the configuration you provided in #55958 and can confirm that mqtt.sensor is picked up.

@peterhoeg
Copy link
Member

#56508 for unifi/ffmpeg

@dotlambda
Copy link
Member Author

I'll merge this within the next 12 hours if noone objects.

@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 2, 2019
@dotlambda dotlambda merged commit a3b6b49 into NixOS:master Mar 3, 2019
@dotlambda
Copy link
Member Author

What do you think about backporting 971187e to 19.03?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants