Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typora: 0.9.64 -> 0.9.68 #58601

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

Commit Message

Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in #56533

Closes #56533

Motivation for this change

Finish #56533

This fixes a crash (incomplete wrapper) so I will be porting to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dtzWill

Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in NixOS#56533

Closes NixOS#56533
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 31, 2019
@dtzWill
Copy link
Member

dtzWill commented Mar 31, 2019 via email

@worldofpeace
Copy link
Contributor Author

Sorry for breakage! (I think it was me, but didn't check innocent)

Oh no it was me. But we're peaceful with the postmortems 😄

@worldofpeace worldofpeace merged commit b641b4d into NixOS:master Mar 31, 2019
@worldofpeace worldofpeace deleted the typora/0.9.68 branch March 31, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants