Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libguestfs-with-appliance: Add package for libguesfs containing libguestfs appliances #60024

Merged
merged 1 commit into from
Apr 23, 2019
Merged

libguestfs-with-appliance: Add package for libguesfs containing libguestfs appliances #60024

merged 1 commit into from
Apr 23, 2019

Conversation

roosemberth
Copy link
Contributor

@roosemberth roosemberth commented Apr 22, 2019 •
edited
Loading

Appliances are necessary when building images using virt-builder.
(e.g. virt-builder -o debian-9.img debian-9)

Signed-off-by: Roosembert Palacios roosembert.palacios@epfl.ch

Motivation for this change

Necessary to run virt-builder. Tested by running virt-builder -o debian-9.img debian-9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Add package for libguesfs containing libguestfs appliances
ecb90ae 
Appliances are necessary when building images using virt-builder.
(e.g. `virt-builder -o debian-9.img debian-9`)

Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Apr 22, 2019
@infinisil infinisil merged commit fe05407 into NixOS:master Apr 23, 2019
@cdepillabout cdepillabout mentioned this pull request May 21, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roosemberth @infinisil