Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metals: init at 0.7.6 #60336

Merged
merged 1 commit into from
Jan 4, 2020
Merged

metals: init at 0.7.6 #60336

merged 1 commit into from
Jan 4, 2020

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Apr 27, 2019

Things done

Initialize metals package. Note that this package includes wrappers for vim, sublime and emacs written according to the package documentation. As I only use emacs, it's the only one properly tested.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Tomahna
Copy link
Contributor Author

Tomahna commented Apr 27, 2019

@chrilves if you want to give it a try, there it is

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 27, 2019
@Tomahna Tomahna force-pushed the metals branch 2 times, most recently from bc49b46 to 2448422 Compare May 8, 2019 16:04
@Tomahna Tomahna changed the title metals: init at 0.5.1 metals: init at 0.5.2 May 13, 2019
@Tomahna Tomahna force-pushed the metals branch 2 times, most recently from 88c8460 to ba63c58 Compare May 13, 2019 18:13
@Tomahna Tomahna force-pushed the metals branch 2 times, most recently from 54c8a1c to d8f81ba Compare June 11, 2019 12:31
@Tomahna Tomahna changed the title metals: init at 0.5.2 metals: init at 0.6.0 Jun 11, 2019
@Tomahna Tomahna changed the title metals: init at 0.6.0 metals: init at 0.6.1 Jun 12, 2019
@Tomahna Tomahna mentioned this pull request Jul 22, 2019
Closed
10 tasks
@Tomahna Tomahna closed this Sep 9, 2019
@Tomahna Tomahna changed the title metals: init at 0.6.1 metals: init at 0.7.2 Sep 9, 2019
@Tomahna Tomahna reopened this Sep 10, 2019
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 10, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
ceedubs
ceedubs approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM and is similar to a derivation for Metals that I've been using.

@Tomahna please feel free to also add me as a maintainer.

@ofborg ofborg bot requested a review from ceedubs September 11, 2019 11:56
@Tomahna Tomahna changed the title metals: init at 0.7.2 metals: init at 0.7.6 Sep 23, 2019
@ofborg ofborg bot requested a review from ceedubs September 23, 2019 19:59
@ofborg ofborg bot requested a review from ceedubs September 24, 2019 07:17
ceedubs
ceedubs approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/69

@ryantm
Copy link
Member

ryantm commented Jan 4, 2020

@GrahamcOfBorg build metals

@ryantm ryantm merged commit bd62dd3 into NixOS:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceedubs ceedubs ceedubs approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.
5 participants
@Tomahna @nixos-discourse @ryantm @ceedubs @lheckemann