Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broadcom_sta: fix build on linux-5.1 #61686

Merged
merged 1 commit into from
May 24, 2019
Merged

broadcom_sta: fix build on linux-5.1 #61686

merged 1 commit into from
May 24, 2019

Conversation

georgewhewell
Copy link
Contributor

@georgewhewell georgewhewell commented May 18, 2019 •
edited
Loading

Motivation for this change

broadcom_sta module no longer compiles under linux 5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Phreedom May 18, 2019 21:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels May 18, 2019
@rembo10 rembo10 mentioned this pull request May 20, 2019
Closed
10 tasks
@rembo10
Copy link
Contributor

rembo10 commented May 20, 2019

This is the same fix as in #61662 (which has some links to bug reports and fixes from other distros) and I can confirm it fixes the issue for me as well.

@infinisil infinisil merged commit 3556df6 into NixOS:master May 24, 2019
@veprbl
Copy link
Member

veprbl commented Sep 20, 2019

backport to 19.03 #69167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgewhewell @rembo10 @veprbl @infinisil