Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-make: 0.22.0 -> 0.22.1 #67151

Merged
merged 1 commit into from
Aug 22, 2019
Merged

cargo-make: 0.22.0 -> 0.22.1 #67151

merged 1 commit into from
Aug 22, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 21, 2019

Motivation for this change

Update cargo-make to the latest release.

Note: doCheck is set as false.
Some tests fail because they need network access. However, Travis-CI ensures a proper build.

cargo-make is a subcommand for cargo. You need to invoke cargo-make via cargo command.
To test the binary files in ./result/bin, consider the following commands:

[john@nixos:~/result/bin] PATH=.:$PATH cargo make --version
cargo-make 0.22.1
[john@nixos:~/result/bin] PATH=.:$PATH ./makers --version
makers 0.22.1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 21, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 938a7e5 into NixOS:master Aug 22, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

@xrelkd thanks!

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 22, 2019

@Ma27 You're welcome!

@xrelkd xrelkd deleted the update/cargo-make branch August 22, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants