Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 0.9.4 -> 0.10.2 #68914

Merged
merged 1 commit into from
Nov 16, 2019
Merged

broot: 0.9.4 -> 0.10.2 #68914

merged 1 commit into from
Nov 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 16, 2019

Motivation for this change

https://github.com/Canop/broot/releases/tag/v0.9.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

Hmm, does the cargoSha256 look right? Double-checking because other hashes are off in my tree, presumably missed a rust-related bump or something.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 7, 2019

Replaced cargo hash with ofborg's computed value, rebased to make sure all good on master.

@ofborg ofborg bot requested a review from magnetophon October 7, 2019 23:23
@dtzWill dtzWill changed the title broot: 0.9.4 -> 0.9.5 broot: 0.9.4 -> 0.10.2 Nov 16, 2019
@ofborg ofborg bot requested a review from magnetophon November 16, 2019 07:43
magnetophon
magnetophon approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review, LGTM!

@dtzWill dtzWill merged commit ed2819a into NixOS:master Nov 16, 2019
@dtzWill dtzWill deleted the update/broot-0.9.5 branch November 16, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon magnetophon approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzWill @magnetophon