Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babeld: add test #71006

Merged
merged 2 commits into from
Oct 12, 2019
Merged

babeld: add test #71006

merged 2 commits into from
Oct 12, 2019

Conversation

mweinelt
Copy link
Member

Motivation for this change

It's a test, it helps discover issues early on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @Fuuzetsu

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 11, 2019
flokli
flokli requested changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the test to nixos/tests/all-tests.nix?

@flokli
Copy link
Contributor

flokli commented Oct 12, 2019

Also, adding

passthru.tests.babel = nixosTests.babel;

to the babel package would make that test easier discoverable.

@mweinelt
Copy link
Member Author

@flokli Done.

@flokli
Copy link
Contributor

flokli commented Oct 12, 2019

@GrahamcOfBorg build babeld.tests

@flokli flokli merged commit aac5207 into NixOS:master Oct 12, 2019
@mweinelt mweinelt deleted the pr/master/babeld/test branch June 22, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @flokli