Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit: 1.12.0 -> 1.13.0 #73491

Merged
merged 3 commits into from
Dec 5, 2019
Merged

unit: 1.12.0 -> 1.13.0 #73491

merged 3 commits into from
Dec 5, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 16, 2019

Motivation for this change

Update nginx unit to version 1.13.0

Changelog:

  • Feature: basic support for HTTP reverse proxying.
  • Feature: compatibility with Python 3.8.
  • Bugfix: memory leak in Python application processes when the close handler was used.
  • Bugfix: threads in Python applications might not work correctly.
  • Bugfix: Ruby on Rails applications might not work on Ruby 2.6.
  • Bugfix: backtraces for uncaught exceptions in Python 3 might be logged with significant delays.
  • Bugfix: explicit setting a namespaces isolation option to false might have enabled it.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Nov 16, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 17, 2019

Added commit to fix this error:
nginx/unit#349
#73513

@alyssais
Copy link
Member

alyssais commented Nov 17, 2019 via email

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 17, 2019

https://www.speedshop.co/2018/03/28/nginx-unit-for-ruby.html - ruby application server.

For example, if need to run applications, one of which supports version 2.4, and the other application only 2.6

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this involves hundreds of rebuilds it should probably target the staging branch.

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 18, 2019

Rebased to staging.

@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 18, 2019
@ofborg ofborg bot added 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 18, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 18, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 18, 2019
pkgs/servers/http/unit/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh self-requested a review December 5, 2019 09:25
@FRidh FRidh merged commit 353ec3f into NixOS:staging Dec 5, 2019
@Izorkin Izorkin deleted the unit branch December 7, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants