Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks #74723

Merged
merged 6 commits into from
Dec 8, 2019
Merged

home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks #74723

merged 6 commits into from
Dec 8, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 30, 2019
@etu etu changed the title home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks [WIP] home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks Nov 30, 2019
@etu etu changed the title [WIP] home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks home-assistant: Init packages needed for ZHA usage of zigpy deconz usb sticks Nov 30, 2019
@etu etu mentioned this pull request Dec 7, 2019
Closed
10 tasks
srhb
srhb approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to squash the two "python3Packages.zigpy-deconz: init at 0.7.0" commits? :)

@etu
Copy link
Contributor Author

etu commented Dec 7, 2019

@srhb Done, that must have been an oversight while rebasing and fixing up during packaging :)

@srhb srhb merged commit 5d5604f into NixOS:master Dec 8, 2019
@etu etu deleted the init-zigpy-deconz branch December 8, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@srhb srhb srhb approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etu @srhb @jonringer