Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpupower: explicitly set CC and LD to allow compilation with e… #74810

Merged
merged 1 commit into from
Dec 2, 2019
Merged

cpupower: explicitly set CC and LD to allow compilation with e… #74810

merged 1 commit into from
Dec 2, 2019

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Dec 1, 2019 •
edited
Loading

Motivation for this change

I tried building linuxPackages with clang. cpupower failed to build, because it tries to use gcc.

Things done

I verified that cpupower builds with clang stdenv (version 9) and successfully built linuxPackages_5_4 with these changes (actually I am writing this on a system with clang built kernel right now).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/compiling-the-linux-kernel-with-clang-llvm/4218/3

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 labels Dec 1, 2019
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2019

@GrahamcOfBorg build cpupower

@Mic92
Copy link
Member

Mic92 commented Dec 2, 2019

@GrahamcOfBorg build linuxPackages.cpupower

@Mic92 Mic92 changed the title cpupower: explicitly set CC and LD to allow compilation with e.g. clang cpupower: explicitly set CC and LD to allow compilation with e… Dec 2, 2019
@Mic92 Mic92 merged commit 2e64e97 into NixOS:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xaverdh @nixos-discourse @Mic92