Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeval: 0.7.3 -> 0.14.0 #74908

Merged
merged 1 commit into from
Dec 4, 2019
Merged

kubeval: 0.7.3 -> 0.14.0 #74908

merged 1 commit into from
Dec 4, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Dec 3, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nicknovitski

@groodt groodt force-pushed the kubeval-0.14.0 branch 2 times, most recently from 725157e to 9d05744 Compare December 3, 2019 11:28
@ofborg ofborg bot requested a review from kalbasit December 3, 2019 11:43
@Br1ght0ne
Copy link
Member

Testing build on darwin
@GrahamcOfBorg build kubeval

@groodt
Copy link
Contributor Author

groodt commented Dec 3, 2019

@filalex77 I don't suppose you're able to look into this one too? #73093

It's been sitting for a while...

@Br1ght0ne
Copy link
Member

Sorry @groodt, but I also don't have merge rights yet :(

I'll ping some maintainers I know to see if we can resolve this and #73093 faster. To said maintainers: sorry if that's not the way to do it.

cc @jonringer @worldofpeace @marsam @Ma27

Br1ght0ne
Br1ght0ne approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on NixOS unstable. (checked with nix-review)

@marsam marsam merged commit 591aee2 into NixOS:master Dec 4, 2019
@marsam
Copy link
Contributor

marsam commented Dec 4, 2019

Thank you @groodt, please feel free to ping me if a PR gets stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@groodt @Br1ght0ne @marsam @cdepillabout