Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove empty inherits #74969

Merged
merged 2 commits into from
Dec 4, 2019
Merged

treewide: remove empty inherits #74969

merged 2 commits into from
Dec 4, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 4, 2019

Motivation for this change

These empty inherits were accidentally introduced by #66585

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@marsam
treewide: remove empty inherits
49c63e4 
These empty inherits were accidentally introduced by #66585
@ofborg ofborg bot added 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Dec 4, 2019
@marsam
Copy link
Contributor Author

marsam commented Dec 4, 2019

you are right, I removed those which I could find

@worldofpeace worldofpeace merged commit b07e790 into NixOS:master Dec 4, 2019
@marsam marsam deleted the remove-empty-inherits branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsam @worldofpeace