Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netpbm: TIFF converters missed #75156

Closed
caadar opened this issue Dec 7, 2019 · 0 comments
Closed

Netpbm: TIFF converters missed #75156

caadar opened this issue Dec 7, 2019 · 0 comments
Labels
0.kind: bug

Comments

@caadar
Copy link
Contributor

caadar commented Dec 7, 2019

Describe the bug
Netpbm misses TIFF converters, such as tifftopnm.

To Reproduce
Steps to reproduce the behavior:

  1. Install nixpkgs.netpbm
  2. Try to find some tiffto* commands.

Expected behavior
TIFF converters installed with Netpbm.

Additional context
libtiff is required to build the following Netpbm programs: pamtotiff, pnmtotiff, pnmtotiffcmyk and
tifftopnm (Netobm Library Prerequisites). Indeed libtiff is input for the nixpkgs.netpbm, but TIFF converters are missed.

Metadata
nix run nixpkgs.nix-info -c nix-info -m output:

 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.87, NixOS, 20.03.git.3140fa8 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.1`
 - channels(user): `""`
 - channels(root): `""`
 - nixpkgs: `/home/user/src/nixos/nixpkgs`
jtojnar added a commit that referenced this issue Feb 25, 2020
@jtojnar
netpbm: Fix tiff support
51fb122 
The build script check whether JPEGLIB and ZLIB are not set to NONE.
We did not set the latter as pkg-config handles zlib requirement
for libpng dependency and the comment in config.mk only talks about
zlib being needed for libpng.

Since libtiff only needs libz for static linking, we turn TIFFLIB_NEEDS_ZLIB
off instead of pointlessly setting ZLIB value.

Closes: #75156
@jtojnar jtojnar closed this as completed in 9018090 Mar 2, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Mar 3, 2020
@jtojnar @dtzWill
netpbm: Fix tiff support
da9729a 
The build script check whether JPEGLIB and ZLIB are not set to NONE.
We did not set the latter as pkg-config handles zlib requirement
for libpng dependency and the comment in config.mk only talks about
zlib being needed for libpng.

Since libtiff only needs libz for static linking, we turn TIFFLIB_NEEDS_ZLIB
off instead of pointlessly setting ZLIB value.

Closes: NixOS#75156
(cherry picked from commit 9018090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caadar