Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlangR22: 22.1.7 -> 22.3 #75430

Merged
merged 1 commit into from
Mar 29, 2020
Merged

erlangR22: 22.1.7 -> 22.3 #75430

merged 1 commit into from
Mar 29, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Dec 10, 2019 •
edited
Loading

Motivation for this change

Keeping things up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny @sjmackenzie @couchemar @gleber

@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.0 erlangR22: 22.1.7 -> 22.2.1 Jan 8, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.1 erlangR22: 22.1.7 -> 22.2.2 Jan 13, 2020
@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.2 erlangR22: 22.1.7 -> 22.2.3 Jan 27, 2020
@cw789
Copy link
Contributor Author

cw789 commented Jan 27, 2020

@the-kenny @sjmackenzie @gleber
Anyone up to help me to get this merged?
Quite a while I keep this PR going.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/103

@cw789
Copy link
Contributor Author

cw789 commented Feb 24, 2020

I've updated to the newest Erlang version once again.

@couchemar
Copy link
Contributor

cc @the-kenny @sjmackenzie @gleber

I think we need this request merged.

@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.3 erlangR22: 22.1.7 -> 22.2.7 Feb 25, 2020
@cw789
Copy link
Contributor Author

cw789 commented Feb 25, 2020

I'm open for feedback, what I can do better...

@vcunat
Copy link
Member

vcunat commented Feb 25, 2020

Side question: is some of you still interested in R18 or R19? #80746

@cw789
Copy link
Contributor Author

cw789 commented Feb 25, 2020

On my side as Elixir user, I would be ok with removing them...
By the way, what's the Erlang R16B02-basho.nix for?

@cw789 cw789 changed the title erlangR22: 22.1.7 -> 22.2.7 erlangR22: 22.1.7 -> 22.3 Mar 17, 2020
@cw789
Copy link
Contributor Author

cw789 commented Mar 17, 2020

cc @the-kenny @sjmackenzie @gleber

I've updated this PR one again.
Could anybody tell me why there is currently really no progress on updating Erlang within nixpkgs?
This PR is now 4 months old.

@vcunat
Copy link
Member

vcunat commented Mar 29, 2020

I don't really know anything about erlang, but I'd hate anything being blocked just because of non-responsive maintainers. Let's verify darwin superficially:
@GrahamcOfBorg build erlangR22

@vcunat vcunat merged commit 804477b into NixOS:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@couchemar couchemar couchemar approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cw789 @nixos-discourse @couchemar @vcunat