-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #75452
Staging next #75452
Conversation
The changes in #67548 broke cross-compilation not for valgrind, but for software relying on valgrind at build-time.
If an empty string is passed to `-idirafter`, it breaks gcc. This commit makes the stdenv less fragile by expanding out the shell glob and ensuring no empty arguments get passed.
* Removes an unused binding that prevents compilation with newer pango * Adds a patch to fix a memory leak
a patch to cmake to correctly locate harfbuzz: https://gitlab.kitware.com/cmake/cmake/issues/19531, needed for more recent pango.
kdeFrameworks: 5.62 -> 5.64; kdeApplications: 19.08.2 -> 19.08.3
meson: 0.51.2 → 0.52.1
stdenv: Fix gcc -idirafter shell glob in cc-wrapper
- add myself as maintainer - license is mit
pango, pygtk: fixing up newer pango and pygtk
libffi: 3.2.1 -> 3.3
Using a function in an if condition when set -e is set doesn't seem to break out or return false which means the workaround from 41ca861 never gets triggered.
In case somebody else is looking into it: I've tracked the ecl build failure to #74855 (comment). |
@@ -76,8 +76,8 @@ stdenv.mkDerivation { | |||
# later. | |||
buildPhase = stdenv.lib.optionalString true '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? the predicate is literally true, just have the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was accidental, I initially wanted to make the workaround conditional for clang 7 but that's really hard to check while the stdenv is still bootstrapping.
Motivation for this change
https://hydra.nixos.org/jobset/nixpkgs/staging-next
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @