Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vit: fix check phase #77781

Merged
merged 1 commit into from
Jan 15, 2020
Merged

vit: fix check phase #77781

merged 1 commit into from
Jan 15, 2020

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jan 15, 2020

Motivation for this change

It broke. See a6d0b81 for a similar fix for a different package affected by the same issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dtzWill January 15, 2020 18:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 15, 2020
@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

LGTM, this is how I had it from the start-- not sure how it failed to make it here, sorry. I can say it works, though! ^_^

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

Unfortunately, python3Packages.tasklib doesn't seem to be building for me on this revision-- I wonder if it builds for you/hydra/anyone if we try it again? Maybe another 2020 bug?

Well, no matter. This looks good for now :).

@arcnmx
Copy link
Member Author

arcnmx commented Jan 15, 2020

Hm, I can force a rebuild of python3Packages.tasklib on nixos-unstable-small and current master on my own machine and it seems to complete without issues.

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020

Well, then certainly isn't worth worrying about re:this PR then :). Thanks for checking!

@dtzWill dtzWill merged commit 712bf54 into NixOS:master Jan 15, 2020
@arcnmx arcnmx deleted the vit-fix branch January 15, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcnmx @dtzWill