-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.10.0 (dev) #78475
Conversation
@xeji since you merged the last pr of dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@infinisil I do not know who is responsible for this to be merged, hence I checked the contributors of this file and saw that you contributed and are a member of Nixpkgs. Can you review and merge this please? |
Please squash commits. |
@ericdallo yes you are right. I also updated dart dev version to dev.9.0 (and successfully repeated all test with that version). |
@infinisil @xeji please, please review or suggest an appropriate reviewer |
@worldofpeace since I have positive experiences with you as a reviewer and your response time I kindly ask you to review or suggest an appropriate reviewer for this package update |
@GrahamcOfBorg build dart dart_dev dart_stable dart_old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the versions in all-packages.nix, or I can't build the dev versions etc.
dart = callPackage ../development/interpreters/dart { };
dart_stable = dart.override { version = "2.0.0"; };
dart_old = dart.override { version = "1.24.3"; };
dart_dev = dart.override { version = "2.0.0-dev.26.0"; };
it'll fail with error: unsupported version/system: 2.0.0-dev.26.0/x86_64-linux
for example on dart_dev
.
I'm nixos's first responder 💖 |
Good to have you on board :-) |
@GrahamcOfBorg build dart dart_dev dart_stable dart_old |
- dart stable: make it default - add aarch64 (arm64) packages - set myself as maintainer
@GrahamcOfBorg build dart dart_dev dart_stable dart_old |
Thanks @GRBurst ✨ |
Motivation for this change
I recently built an app using
flutter
. I ran into multiple issues, one being that the current version ofdart
in nixos is not compatible with the newestflutter
version. Currently, adding support forflutter
is discussed in this issue #36759 and it looks promising to get added into the nixos ecosystem :-)In order to be able to build the app, I had to update the dart version. There is another issue complaining about the old version of dart in #78183 and another pull request which is outdated again #60607
Please do not hesitate to reply, since I would be happy having this updated in the nixos packages.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)