Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.10.0 (dev) #78475

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

GRBurst
Copy link
Member

@GRBurst GRBurst commented Jan 25, 2020

Motivation for this change

I recently built an app using flutter. I ran into multiple issues, one being that the current version of dart in nixos is not compatible with the newest flutter version. Currently, adding support for flutter is discussed in this issue #36759 and it looks promising to get added into the nixos ecosystem :-)

In order to be able to build the app, I had to update the dart version. There is another issue complaining about the old version of dart in #78183 and another pull request which is outdated again #60607

Please do not hesitate to reply, since I would be happy having this updated in the nixos packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GRBurst
Copy link
Member Author

GRBurst commented Jan 27, 2020

@xeji since you merged the last pr of dart dart: 1.24.3 -> 2.0.0, I added you as reviewer ;-)

Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GRBurst
Copy link
Member Author

GRBurst commented Feb 12, 2020

@infinisil I do not know who is responsible for this to be merged, hence I checked the contributors of this file and saw that you contributed and are a member of Nixpkgs. Can you review and merge this please?

@ericdallo
Copy link
Member

Please squash commits.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Feb 18, 2020
@ericdallo
Copy link
Member

@GRBurst, I mean squash all PR commits into single one dart: 2.7.0 -> 2.7.1 and 2.0.0-dev.26.0 -> 2.8.0-dev.5.0. This way makes things cleaner and easy to read on master commit history 😅

@GRBurst GRBurst removed the request for review from xeji February 19, 2020 08:16
@GRBurst GRBurst changed the title dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.5.0 (dev) dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.9.0 (dev) Feb 19, 2020
@GRBurst
Copy link
Member Author

GRBurst commented Feb 19, 2020

@ericdallo yes you are right. I also updated dart dev version to dev.9.0 (and successfully repeated all test with that version).

@GRBurst
Copy link
Member Author

GRBurst commented Feb 19, 2020

@infinisil @xeji please, please review or suggest an appropriate reviewer

@GRBurst
Copy link
Member Author

GRBurst commented Feb 25, 2020

@worldofpeace since I have positive experiences with you as a reviewer and your response time I kindly ask you to review or suggest an appropriate reviewer for this package update

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build dart dart_dev dart_stable dart_old

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the versions in all-packages.nix, or I can't build the dev versions etc.


  dart = callPackage ../development/interpreters/dart { };
  dart_stable = dart.override { version = "2.0.0"; };
  dart_old = dart.override { version = "1.24.3"; };
  dart_dev = dart.override { version = "2.0.0-dev.26.0"; };

it'll fail with error: unsupported version/system: 2.0.0-dev.26.0/x86_64-linux for example on dart_dev.

@worldofpeace
Copy link
Contributor

@worldofpeace since I have positive experiences with you as a reviewer and your response time I kindly ask you to review or suggest an appropriate reviewer for this package update

I'm nixos's first responder 💖

@GRBurst
Copy link
Member Author

GRBurst commented Feb 27, 2020

You need to update the versions in all-packages.nix, or I can't build the dev versions etc.


  dart = callPackage ../development/interpreters/dart { };
  dart_stable = dart.override { version = "2.0.0"; };
  dart_old = dart.override { version = "1.24.3"; };
  dart_dev = dart.override { version = "2.0.0-dev.26.0"; };

it'll fail with error: unsupported version/system: 2.0.0-dev.26.0/x86_64-linux for example on dart_dev.

Good to have you on board :-)
I see - did not updated all-packages.nix after the updates appropriately 👍

@GRBurst GRBurst changed the title dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.9.0 (dev) dart: 2.0.0 -> 2.7.1 (stable) + 2.0.0 -> 2.8.0-dev.10.0 (dev) Feb 27, 2020
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 27, 2020
@GRBurst
Copy link
Member Author

GRBurst commented Feb 27, 2020

@GrahamcOfBorg build dart dart_dev dart_stable dart_old

- dart stable: make it default
- add aarch64 (arm64) packages
- set myself as maintainer
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build dart dart_dev dart_stable dart_old

@worldofpeace worldofpeace merged commit 14474ff into NixOS:master Feb 27, 2020
@worldofpeace
Copy link
Contributor

Thanks @GRBurst

This was referenced Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants