Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fceux: 2.2.3 -> 2020-01-29 #78943

Merged
merged 1 commit into from
Feb 8, 2020
Merged

fceux: 2.2.3 -> 2020-01-29 #78943

merged 1 commit into from
Feb 8, 2020

Conversation

scubed2
Copy link
Contributor

@scubed2 scubed2 commented Jan 31, 2020 •
edited
Loading

Motivation for this change

Version bump for Python 3 compatibility within scons build rule for
#75877

I've manually, locally built with both Python 2 and Python 3 (using above pull request patched in).

I'm using a github snapshot instead of a release because there haven't been any formal releases since 2.2.3 in 2016, but there have been github updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@scubed2 scubed2 mentioned this pull request Jan 31, 2020
Merged
24 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 31, 2020
primeos
primeos requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the move to GitHub (source) and there might be new releases soon (source).

@scubed2 could you follow e.g. https://github.com/TASVideos/fceux/releases.atom to be notified about new releases?

After the name change this should be good to go, thanks :)

pkgs/misc/emulators/fceux/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/fceux/default.nix Outdated Show resolved Hide resolved
@primeos primeos changed the title fceux: 2.2.3 -> 2.2.3-20200129 fceux: 2.2.3 -> 2020-01-29 Feb 8, 2020
primeos
primeos approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks :)

@primeos primeos merged commit 4a4834f into NixOS:master Feb 8, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 9, 2020
@scubed2 @dtzWill
fceux: 2.2.3 -> 2020-01-29 (NixOS#78943)
72363c5 
(cherry picked from commit 4a4834f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scubed2 @primeos