Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pijul not building on unstable #79150

Closed
gilescope opened this issue Feb 3, 2020 · 0 comments · Fixed by #79223
Closed

pijul not building on unstable #79150

gilescope opened this issue Feb 3, 2020 · 0 comments · Fixed by #79223
Assignees
@primeos
Labels
0.kind: bug Something is broken 6.topic: rust

Comments

@gilescope
Copy link

Describe the bug
Seems a compile error in a cargo dependency:

   Compiling thrussh v0.20.7
error[E0382]: assign to part of moved value: `newkeys`
   --> /build/pijul-0.12.0-vendor/thrussh/src/client/connection.rs:550:13
    |
539 |             let mut newkeys = kexdhdone.compute_keys(
    |                 ----------- move occurs because `newkeys` has type `session::NewKeys`, which does not implement the `Copy` trait
...
549 |             session.0.kex = Some(Kex::NewKeys(newkeys));
    |                                               ------- value moved here
550 |             newkeys.sent = true;
    |             ^^^^^^^^^^^^^^^^^^^ value partially assigned here after move

To Reproduce
Steps to reproduce the behavior:
add package pijul to home-manager.
@gilescope gilescope added the 0.kind: bug Something is broken label Feb 3, 2020
@primeos primeos self-assigned this Feb 4, 2020
primeos added a commit to primeos/nixpkgs that referenced this issue Feb 4, 2020
@primeos
pijul: Fix the build (broke due to a more recent Rust version)
434ff94 
This uses an upstream patch [0] to fix a compatibility error with a new
version of Rust. Fix NixOS#79150.

Unfortunately patching Rust dependencies in Nixpkgs turned out to be way
more hacky than I expected (maybe there is a nicer way?), but it should
be fine for now.

A new release might follow soonish [1] so that we can drop the patches.

References:
- https://nest.pijul.com/pijul_org/pijul/discussions/401
- https://nest.pijul.com/pijul_org/thrussh/discussions/31

[0]: https://nest.pijul.com/pijul_org/thrussh:master/patches/AsyuWkJg4jAwNaG3H1yv1kbECx5E3GQAtjzXWBDB8yEGMswyfKbxKvYmAGWCohTVaTipdvF8mHh63yU5PTr5F9py
[1]: https://discourse.pijul.org/t/is-this-project-still-active-yes-it-is/451
@primeos primeos mentioned this issue Feb 4, 2020
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Feb 4, 2020
@primeos @dtzWill
pijul: Fix the build (broke due to a more recent Rust version)
bb65d6a 
This uses an upstream patch [0] to fix a compatibility error with a new
version of Rust. Fix NixOS#79150.

Unfortunately patching Rust dependencies in Nixpkgs turned out to be way
more hacky than I expected (maybe there is a nicer way?), but it should
be fine for now.

A new release might follow soonish [1] so that we can drop the patches.

References:
- https://nest.pijul.com/pijul_org/pijul/discussions/401
- https://nest.pijul.com/pijul_org/thrussh/discussions/31

[0]: https://nest.pijul.com/pijul_org/thrussh:master/patches/AsyuWkJg4jAwNaG3H1yv1kbECx5E3GQAtjzXWBDB8yEGMswyfKbxKvYmAGWCohTVaTipdvF8mHh63yU5PTr5F9py
[1]: https://discourse.pijul.org/t/is-this-project-still-active-yes-it-is/451

(cherry picked from commit 434ff94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@primeos primeos

Labels
0.kind: bug Something is broken 6.topic: rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pijul: Fix the build (broke due to a more recent Rust version) primeos/nixpkgs
3 participants
@veprbl @gilescope @primeos