Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cocoapods-beta: 1.9.0.beta.2 -> 1.9.0.beta.3 #79489

Merged
merged 1 commit into from
Feb 8, 2020
Merged

cocoapods-beta: 1.9.0.beta.2 -> 1.9.0.beta.3 #79489

merged 1 commit into from
Feb 8, 2020

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Feb 8, 2020

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Feb 8, 2020
@marsam marsam merged commit a7eca70 into NixOS:master Feb 8, 2020
@lilyball lilyball deleted the cocoapods-beta branch February 8, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyball @marsam