-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fonts/gdouros: correct license to unfree #79679
Conversation
License at last update: https://web.archive.org/web/20181228102831/http://users.teilar.gr/%7Eg1951d/License.pdf |
Looks like the noncommercial requirement was added between January and March 2018; the licence forbidding redistribution first appeared in the April 20 2018 archive, so any builds on Hydra from then onwards are problematic. |
Is there any statement anywhere from George Douros, the maintainer of these fonts, on this? I found multiple other projects (arch linux, some homebrew thing, some math font thing(?)) that stumbled upon this license change, but none of the discussions had any reasoning from the guy. While he most likely had/has some reason for this license, he might also not be aware of what this change in license means. Maybe someone should try and reach out to him to figure out if this is actually what he intended and if he might want to change the licenses again. |
I haven't found anything to that effect. I'm happy to try emailing and asking if he's considered fully free font licences, but unfortunately I doubt you go from "do anything" to "do anything noncommercial" to "do almost nothing" without intending the restrictions. If a new version under a free licence is released, that would be great, but the current package version's licence should probably be fixed until then anyway. |
@GrahamcOfBorg build aegan aegyptus akkadian assyrian eemusic maya symbola textfonts unidings |
pkgs/data/fonts/gdouros/default.nix
Outdated
homepage = http://users.teilar.gr/~g1951d/; | ||
hydraPlatforms = []; # redistribution not permitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hydra.nixos.org won't build unfree packages regardless of this attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
does this need backporting to 20.03 too? |
13065b2
to
05a9b7f
Compare
Actually, yes! (e.g. see #81337) |
Motivation for this change
I assume the licence for these fonts changed at some point, but the current licensing conditions are actually rather byzantine and definitely non-Free. They actually prohibit redistribution, so the existing Hydra builds of these packages (example) are a liability; I'm not sure who (if anyone) would be able to purge them.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)