Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraria-server: 1.3.5.3 -> 1.4.0.3 #87966

Merged
merged 1 commit into from
May 22, 2020
Merged

terraria-server: 1.3.5.3 -> 1.4.0.3 #87966

merged 1 commit into from
May 22, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented May 16, 2020

Also use autoPatchelfHook and nixfmt it

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested a review from Chiiruno May 16, 2020 17:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 16, 2020
@CloudArtAdmins
Copy link
Contributor

This built and ran for me.

@samhza
Copy link
Contributor

samhza commented May 17, 2020

1.4.0.1 has been superseded by 1.4.0.2, which for some reason isn't available from https://terraria.org/server/terraria-server-1402.zip, but instead https://terraria.org/system/dedicated_servers/archives/000/000/036/original/terraria-server-1402.zip.

@dasJ dasJ changed the title terraria-server: 1.3.5.3 -> 1.4.0.1 terraria-server: 1.3.5.3 -> 1.4.0.2 May 17, 2020
@dasJ
Copy link
Member Author

dasJ commented May 17, 2020

@erebid Thanks, updated

@samhza
Copy link
Contributor

samhza commented May 21, 2020

Terraria has now been updated to 1.4.0.3, and the server download URL is https://terraria.org/system/dedicated_servers/archives/000/000/037/original/terraria-server-1403.zip

@dasJ
terraria-server: 1.3.5.3 -> 1.4.0.3
466fb98 
Also use autoPatchelfHook and nixfmt it
@dasJ dasJ changed the title terraria-server: 1.3.5.3 -> 1.4.0.2 terraria-server: 1.3.5.3 -> 1.4.0.3 May 21, 2020
@dasJ
Copy link
Member Author

dasJ commented May 21, 2020

@erebid Thanks, updated

@ajs124 ajs124 self-requested a review May 21, 2020 17:43
@dasJ dasJ requested review from Lassulus and ajs124 May 21, 2020 17:44
@Lassulus Lassulus merged commit 571212e into NixOS:master May 22, 2020
@dasJ dasJ deleted the upd/terraria14 branch May 22, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dasJ @CloudArtAdmins @samhza @ajs124 @Lassulus