-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elm: add the platform and helpful scripts #9233
Conversation
This patch looks fine to me. I wonder about two things:
|
EDIT: Elm does have a package library, but I don't see any use case or a way to package it -- it would require changes in their package manager. |
Thank you for the explanations! I wish the Elm people would deprecate their package on Hackage if they don't intend to maintain it there anymore. |
Anyway, the code looks fine to me. Merge away if you feel that it's ready. Also, I'm about to push 9e7ce5b to disable the broken Elm variants in the haskellPackages set. |
I came up with my own hack to get the latest Elm stuff before I saw this. Your approach is much better (^_^). My hack is here if you want to take a look. I kept the Elm packages a part of haskellPackages, just providing versions that sourced from GitHub instead of Hackage. My only suggestion for this pull request is that |
@evancz can probably mark the Hackage packages as deprecated |
They are all marked as deprecated. |
Thanks! |
Also paging
I just noticed your packages was also marked broken in 9e7ce5b#diff-8f392bd0e4fd42a66d9e0cd4901ec287R919. Are they deprecated? I'm sure some of these are still actively maintained on Hackage (not part of the Elm platform). These all depend on deprecated packages, so I'm guessing it's safe to mark deprecated:
Please mark as deprecated on Hackage if you don't mind. |
I personally haven't used any package distribution other than hackage and I'd appreciate if someone could tell me what the canonical way of publishing elm related software is now so I can submit upstream changes to the right place. |
@rehno-lindeque |
@peti I believe there was a misunderstanding (correct me if I'm wrong!) -- Elm platform consists only of
Other packages are not in the platform (nor in my PR) and their authors still release them on Hackage. EDIT: I've looked though now-broken package list. Those packages do depend on
|
@doshitan Thanks for your advice! I'll fix this, add some documentation and this should be good to go. |
@JustusAdam I think it's probably something you can bring up in the elm-discuss mailinglist, we probably want to avoid spamming this PR. (I believe Hackage should be fine as long as you don't depend on Elm platform packages). |
e65838a
to
c8099f3
Compare
elm: add the platform and helpful scripts
Sorry for the dealy on my part, I just depricated elm-build-lib, it hasn't On Mon, Aug 17, 2015 at 12:32 PM, Nikolay Amiantov <notifications@github.com
|
cc @peti -- I haven't integrated this into haskell-modules, instead using overrides to add needed packages. Maybe we want to do this some other way?
TODO: