libvpx: 1.7.0 -> 1.9.0 #100210
Merged
libvpx: 1.7.0 -> 1.9.0 #100210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This move to 1.9 (technically the move to 1.8) broke libav_12 googling these symbols finds references that say there were removed in libvpx 1.8. There isn't a newer version of libav released yet, so I would guess the solution may be to still provide libvpx 1.7 (with this patch on 1.8 and 1.9 are made available)? |
|
Never mind, I found a patch for libav. It looks reasonable, and it works for building against libvpx >= 1.8, so I'll open up a pull request to add that against libav instead. |
11 tasks
Mindavi
added a commit
to Mindavi/nixpkgs
that referenced
this pull request
Jun 16, 2021
This is done by removing some warnings that are not supported by the cross-compiler. We also need to disable the --enable-external-build flag, which breaks the build completely. This PR: NixOS#100210 added the flag, but it doesn't explain why it was added. It also doesn't show any attempt at trying to cross-compile for either darwin or aarch64. So let's remove it again, since it 'just' seems to break the build anyway. - drop commented out configure flags - be (more) explicit in patchShebangs - libvpx_1_8: be explicit about patchShebangs, remove commented flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/webmproject/libvpx/releases/tag/v1.8.0
https://github.com/webmproject/libvpx/releases/tag/v1.8.1
https://github.com/webmproject/libvpx/releases/tag/v1.8.2
https://github.com/webmproject/libvpx/releases/tag/v1.9.0
Things done
sandboxinnix.confon non-NixOS linux)