Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvpx: 1.7.0 -> 1.9.0 #100210

Merged
merged 1 commit into from Oct 13, 2020
Merged

libvpx: 1.7.0 -> 1.9.0 #100210

merged 1 commit into from Oct 13, 2020

Conversation

@TredwellGit
Copy link
Member

@TredwellGit TredwellGit commented Oct 11, 2020

Motivation for this change

https://github.com/webmproject/libvpx/releases/tag/v1.8.0
https://github.com/webmproject/libvpx/releases/tag/v1.8.1
https://github.com/webmproject/libvpx/releases/tag/v1.8.2
https://github.com/webmproject/libvpx/releases/tag/v1.9.0

Things done
@ofborg ofborg bot requested a review from codyopel Oct 11, 2020
@gebner gebner merged commit 2424c42 into NixOS:staging Oct 13, 2020
19 checks passed
@TredwellGit TredwellGit deleted the libvpx branch Oct 14, 2020
@twhitehead
Copy link
Contributor

@twhitehead twhitehead commented Jan 29, 2021

This move to 1.9 (technically the move to 1.8) broke libav_12

nix build nixpkgs.libav_12
...
  libavcodec/libvpx.c:66:42: error: 'VPX_IMG_FMT_RGB555_LE' undeclared (first use in this function); did you mean 'AV_PIX_FMT_RGB555LE'?
     66 |     case AV_PIX_FMT_RGB555LE:     return VPX_IMG_FMT_RGB555_LE;
        |                                          ^~~~~~~~~~~~~~~~~~~~~
        |                                          AV_PIX_FMT_RGB555LE
  libavcodec/libvpx.c:70:42: error: 'VPX_IMG_FMT_444A' undeclared (first use in this function); did you mean 'VPX_IMG_FMT_I440'?
     70 |     case AV_PIX_FMT_YUVA444P:     return VPX_IMG_FMT_444A;
        |                                          ^~~~~~~~~~~~~~~~
        |                                          VPX_IMG_FMT_I440
  make: *** [Makefile:48: libavcodec/libvpx.o] Error 1
  make: *** Waiting for unfinished jobs....

googling these symbols finds references that say there were removed in libvpx 1.8.

There isn't a newer version of libav released yet, so I would guess the solution may be to still provide libvpx 1.7 (with this patch on 1.8 and 1.9 are made available)?

@twhitehead
Copy link
Contributor

@twhitehead twhitehead commented Jan 29, 2021

Never mind, I found a patch for libav. It looks reasonable, and it works for building against libvpx >= 1.8, so I'll open up a pull request to add that against libav instead.

Mindavi added a commit to Mindavi/nixpkgs that referenced this issue Jun 15, 2021
This is done by removing some warnings that are not supported by the
cross-compiler.

We also need to disable the --enable-external-build flag, which breaks
the build completely.
This PR: NixOS#100210 added the flag,
but it doesn't explain why it was added. It also doesn't show any
attempt at trying to cross-compile for either darwin or aarch64. So
let's remove it again, since it 'just' seems to break the build anyway.
@Mindavi Mindavi mentioned this pull request Jun 15, 2021
11 tasks
Mindavi added a commit to Mindavi/nixpkgs that referenced this issue Jun 16, 2021
This is done by removing some warnings that are not supported by the
cross-compiler.

We also need to disable the --enable-external-build flag, which breaks
the build completely.
This PR: NixOS#100210 added the flag,
but it doesn't explain why it was added. It also doesn't show any
attempt at trying to cross-compile for either darwin or aarch64. So
let's remove it again, since it 'just' seems to break the build anyway.

- drop commented out configure flags
- be (more) explicit in patchShebangs
- libvpx_1_8: be explicit about patchShebangs, remove commented flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants