-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Qt5.X -> Qt5.15 (when possible) #102840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tremendous work! Did you test each and every package to build and run right?
Overall I approve, but the commit messages sometimes miss some details of other changes, it might help to get this approved but I wouldn't make this a blocker.
Yes I built and run all the executables, just to check it starts. For the commit messages, I can see to improve them, at least the ones where an update was needed. |
Well done 👏. |
Most of the effort is done by my cpu and its fan 😏 |
d8f8754
to
0ae54d6
Compare
I force pushed with more details in the commit messages, please tell me if you need more |
d892174
to
6deabf8
Compare
Pushed after a rebase to fix merge conflicts. Ideally I think every usage of a pinned |
Thank you, I will continue to add other apps, and I think we can think to merge this PR, I will start another PR for to continue this process otherwise we will have more and more conflicts |
* Port to Qt5.15 in the process * Cleanup the derivation to use new style
Fixes build for Qt5.15 Split output to mutilple outputs to reduce user closure size
moved the initial qtcurve package to mkLibsForQt5 function to decouple from Qt5 version added an alias qtcurve -> libsForQt5.qtcurve for backward compatibility add option to disable gtk2 support (still enabled by default)
Did not touch the dependency to python27 but may require another PR
obs-nvi was not touched but should be modified as well, it requires a custom download that I don't use, so I prefer to let official maintainer do it.
94b007f
to
8b0dee1
Compare
Rebase done |
LGTM failures exist on master
|
I guess I start looking the other errors |
either way, this is still an improvement. Thanks! :) |
That's a regression from the last time I tried to build kmymoney - it fails due to xmlsec not building: https://gist.github.com/doronbehar/4b34941feb73855eb307b3470d12dff2 |
@freezeboy when you rebased it you forced pushed and forgot some commits of mine :(. For instance qtwebkit was fixed there. |
Motivation for this change
I tried to migrate the software still using Qt5.12 to a newer version, sometimes I had to update the software to make it work.
Among the reasons blocking the packages, I already spotted:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)