haskellPackages.hakyll: unbreak

[vaibhavsagar]

Motivation for this change

Hakyll is currently broken on 20.09. I fixed it by massaging jaspervdj/hakyll@f24c587 and adding it in as a patch.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[maralorn]

@GrahamcOfBorg build haskellPackages.hakyll

[maralorn]

@vaibhavsagar For future reference: You don‘t need to copy patches like that into nixpkgs. It normally suffices to use pkgs.fetchpatch and github offers various easy possibilities to get an url that returns a valid patch for a commit or pr. There are a lots of examples for this in the haskell configuration-*.nix files.

[maralorn]

Thanks! Looks good to me.

[vaibhavsagar]

@maralorn that wouldn't have worked in this case, since the commit includes changes to files that aren't in the released package. Thanks for letting me know though!

[maralorn]

Don‘t underestimate the raw undocumented powers of fetchpatch. It e.g. has includes and excludes lists as optional parameters. It sounds like they could have helped in this context.

[ghost]

/* hackage-packages.nix is an auto-generated file -- DO NOT EDIT! */

You should remove it from pkgs/development/haskell-modules/configuration-hackage2nix.yaml see #73755

[cdepillabout]

@gnidorah

#104375 (comment)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-ghc-default-version-8-10-2-package-versions-now-from-stackage-nightly/10117/32