libtorrentRasterbar: 1.2.6 -> 2.0.1

[ghost]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[ghost]

This breaks qbittorrent build

[ghost]

@GrahamcOfBorg build qbittorrent

[ghost]

Appearently 2.x is backwards-compatible to previous versions when built with the right options, while the fix release 1.2.11 broke things that compiled with 1.2.6. So I updated deluge-2_x and qbittorrent both to libtorrent 2.0.x and removed libtorrent 1.2.x.

[ghost]

Nope nope nope. While qbittorrent refuses to build with 1.2.11, deluge doesn't work correctly with 2.0.x.

[prusnak]

We might consider treewide rename libtorrentRasterbar - > libtorrent-rasterbar to match the upstream name, but that's just an idea (and maybe for another PR).

Also we could rename 2.0/default.nix to default.nix and 1.2/default.nixto1.2.nixwhile the latter will just call the former and override theversionandsrc` attributes. (But that's only when these two files are very very similar to each other, I have not checked the other contents).

[ghost]

These kinds of changes can lead to huge bikeshedding discussions. I don't really care if it's changed, but I'd like to keep the discussion out of this PR.

I'd like to get one more review that explicitly confirms the new libtorrent 2.0.x works fine with qbittorrent. I have only tested deluge extensively since I am running it myself.

[prusnak]

These kinds of changes can lead to huge bikeshedding discussions.

I agree, that's why I approved this PR and only added the ideas as a separate comment.

[ghost]

@GrahamcOfBorg eval

[SuperSandro2000]

Can you solve the eval error from ofborg?

[ghost]

Can you solve the eval error from ofborg?

Yes, should be done with the last push.

[ghost]

@GrahamcOfBorg build qbittorrent deluge deluge-1_x

[SuperSandro2000]

@ofborg eval

[ghost]

@ofborg eval

Does running eval manually make a difference? I already saw the eval results for the latest commit before.

[SuperSandro2000]

Does running eval manually make a difference? I already saw the eval results for the latest commit before.

It should not make any difference.
I had the tab open before that and it did only update shortly after I commented.

[SuperSandro2000]

Result of nixpkgs-review pr 107194 run on x86_64-darwin 1

8 packages marked as broken and skipped:

• deluge
• deluge-2_x
• libtorrentRasterbar
• libtorrentRasterbar-1_2_x
• libtorrentRasterbar-2_0_x
• python37Packages.libtorrentRasterbar
• python38Packages.libtorrentRasterbar
• python39Packages.libtorrentRasterbar

[ghost]

Thanks! So did it build anything? I'm a bit confused because it doesn't list libtorrentRasterbar-1_1_x. Just out of curiousity: can you try running something like:

NIXPKGS_ALLOW_BROKEN=1 nix build -f https://github.com/petabyteboy/nixpkgs/archive/feature/libtorrentrasterbar-1-2-11.tar.gz deluge
NIXPKGS_ALLOW_BROKEN=1 nix build -f https://github.com/petabyteboy/nixpkgs/archive/feature/libtorrentrasterbar-1-2-11.tar.gz qbittorrent

[SuperSandro2000]

NIXPKGS_ALLOW_BROKEN=1 nix build -f https://github.com/petabyteboy/nixpkgs/archive/feature/libtorrentrasterbar-1-2-11.tar.gz deluge

yeah it builds them.

[ghost]

I will open a third PR to attempt to unbreak them on darwin. I did some more extensive testing on qbittorrent so I'll go ahead with this.