Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] llvmPackages_8.llvm: fix build with gcc 10 #108017

Merged
merged 1 commit into from
Dec 31, 2020
Merged

[staging-next] llvmPackages_8.llvm: fix build with gcc 10 #108017

merged 1 commit into from
Dec 31, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Dec 31, 2020

Applies a patch from the gentoo bugtracker: https://bugs.gentoo.org/732094

Builds llvmPackages_8.llvm and dependee ccls, as reported broken in #89793 (comment)

cc @MetaDark @FRidh

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns r-burns changed the title llvmPackages_8.llvm: fix build with gcc 10 [staging-next] llvmPackages_8.llvm: fix build with gcc 10 Dec 31, 2020
@kira-bruneau
Copy link
Contributor

Thanks @r-burns! It looks like the patch is based on a change submitted upstream: https://reviews.llvm.org/file/data/tvo2b5dbskz6ybaz2zcn/PHID-FILE-lrja2af5rozq3grqej5g/file, but the upstream patch contains the whole context of the file, which is probably unnecessary.

I'm just waiting for the build to finish to verify the fix.

kira-bruneau
kira-bruneau approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished verifying and everything seems good. Thanks again @r-burns!

@FRidh FRidh merged commit d6e3307 into NixOS:staging-next Dec 31, 2020
@FRidh
Copy link
Member

FRidh commented Dec 31, 2020

Thanks!

@r-burns r-burns deleted the llvm8 branch December 31, 2020 08:13
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-burns @kira-bruneau @FRidh @rrbutani