Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: fix build on darwin #108618

Merged
merged 1 commit into from
Jan 6, 2021
Merged

nomad: fix build on darwin #108618

merged 1 commit into from
Jan 6, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 6, 2021

Motivation for this change

Regression introduced by #108341
cc: @cpcloud

Fixes #108603
cc: @sirn

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 6, 2021
@cpcloud
Copy link
Contributor

cpcloud commented Jan 6, 2021

Ah whoops! Thanks for fixing. I guess there isn't CI for darwin builds?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 6, 2021
@marsam
Copy link
Contributor Author

marsam commented Jan 6, 2021

I guess there isn't CI for darwin builds?

yeah, currently there are no @ofborg builders for darwin

@marsam marsam merged commit 1f298db into NixOS:master Jan 6, 2021
@marsam marsam deleted the fix-nomad-darwin branch January 6, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nomad cannot be installed on darwin
2 participants
@marsam @cpcloud