qemu: set localstatedir #112886
Merged
qemu: set localstatedir #112886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
TredwellGit
approved these changes
Feb 12, 2021
10 tasks
SuperSandro2000
added
the
2.status: merge conflict
|
@ofborg eval |
|
Still important to me. Let me know if I can take over and shepherd the PR so that it can get merged. |
Feel free. It would also be great if we could use a patch instead of sed. |
10 tasks
Otherwise qemu-qa, qemu-pr-helper, and virtiofsd, try to write to $out/var at runtime. Fixes: NixOS#113909 Fixes: NixOS#112886
alyssais
force-pushed
the
qemu-localstatedir
branch
from
cb4885b
to
cb3731a
Compare
ofborg
bot
removed
the
2.status: merge conflict
|
I'm going to merge this one. The reason I used a sed is that there's a
lot of churn in that file, so patches will keep breaking with new QEMU
versions.
Sorry for not being around @RaitoBezarius, and thanks for your work in
the meantime.
|
|
Thank you a lot for your work @alyssais ! |
risicle
pushed a commit
to risicle/nixpkgs
that referenced
this pull request
Apr 27, 2021
Otherwise qemu-qa, qemu-pr-helper, and virtiofsd, try to write to $out/var at runtime. Fixes: NixOS#113909 Fixes: NixOS#112886 (cherry picked from commit 8e71416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise qemu-qa, qemu-pr-helper, and virtiofsd, try to write to
$out/var at runtime.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)