Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.redhat.java: init at 0.76.0 #116941

Merged
merged 1 commit into from
Mar 20, 2021
Merged

vscode-extensions.redhat.java: init at 0.76.0 #116941

merged 1 commit into from
Mar 20, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add support for Language Support for Java(TM) by Red Hat VS Code extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 19, 2021
@SuperSandro2000 SuperSandro2000 merged commit f84b4b9 into NixOS:master Mar 20, 2021
@collares
Copy link
Member

Something went wrong with the versionAtLeast check, and this is blocking channels: https://nix-cache.s3.amazonaws.com/log/zb6c22znzcvcnjkdmar5ylj3944vy1a1-nixpkgs-tarball-21.05pre277906.c430ccbb77a.drv

@collares
Copy link
Member

collares commented Mar 21, 2021

@siraben
Copy link
Member

siraben commented Mar 22, 2021

This breaks nixpkgs-review on darwin

$ nix-env -f /Users/siraben/.cache/nixpkgs-review/rev-64ed9a9a999bf1f8d44f8fb8dd2ee307de1aa3de-dirty/nixpkgs -qaP --xml --out-path --show-trace --meta
error: attribute 'version' missing

       at /Users/siraben/.cache/nixpkgs-review/rev-64ed9a9a999bf1f8d44f8fb8dd2ee307de1aa3de-dirty/nixpkgs/pkgs/misc/vscode-extensions/default.nix:607:44:

          606|           license = lib.licenses.epl20;
          607|           broken = lib.versionAtLeast "11" jdk.version;
             |                                            ^
          608|         };

       … while evaluating 'versionOlder'

@ajs124
Copy link
Member

ajs124 commented Mar 22, 2021

This has been broken without response by the author or committer for 2 days, I'm inclined to just revert this instead of blocking nixos-unstable-small for longer.

@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Mar 22, 2021

This has been broken without response by the author or committer for 2 days, I'm inclined to just revert this instead of blocking nixos-unstable-small for longer.

The issue is I'm not sure what the correct course of action is. Remove the check or add a version to jdk on darwin?

cc @SuperSandro2000 @jonringer

@collares
Copy link
Member

See also #117214

sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Mar 22, 2021
lib.versionAtLeast a b ~=~ a >= b, not the other way round.
NixOS#116941 (comment)
sternenseemann added a commit that referenced this pull request Mar 22, 2021
lib.versionAtLeast a b ~=~ a >= b, not the other way round.
#116941 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants