-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-extensions.redhat.java: init at 0.76.0 #116941
vscode-extensions.redhat.java: init at 0.76.0 #116941
Conversation
Something went wrong with the |
|
This breaks nixpkgs-review on darwin $ nix-env -f /Users/siraben/.cache/nixpkgs-review/rev-64ed9a9a999bf1f8d44f8fb8dd2ee307de1aa3de-dirty/nixpkgs -qaP --xml --out-path --show-trace --meta
error: attribute 'version' missing
at /Users/siraben/.cache/nixpkgs-review/rev-64ed9a9a999bf1f8d44f8fb8dd2ee307de1aa3de-dirty/nixpkgs/pkgs/misc/vscode-extensions/default.nix:607:44:
606| license = lib.licenses.epl20;
607| broken = lib.versionAtLeast "11" jdk.version;
| ^
608| };
… while evaluating 'versionOlder' |
This has been broken without response by the author or committer for 2 days, I'm inclined to just revert this instead of blocking |
The issue is I'm not sure what the correct course of action is. Remove the check or add a version to |
See also #117214 |
lib.versionAtLeast a b ~=~ a >= b, not the other way round. NixOS#116941 (comment)
lib.versionAtLeast a b ~=~ a >= b, not the other way round. #116941 (comment)
Motivation for this change
Add support for Language Support for Java(TM) by Red Hat VS Code extension.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)