Improve slurm service configuration #11870
Conversation
|
By analyzing the blame information on this pull request, we identified @jagajaga to be a potential reviewer |
|
I think it's better to do trick like here https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/display-managers/slim.nix#L130. It will be like yours number 2. |
|
@lancelotsix if you need slurm utilities to know where the conf file is, you can use the existing wrapper machinery to wrap the individual utilities and set an environment variable for them |
lsix
changed the title
|
Thanks for the feedback. I'll change that ASAP. |
lsix
force-pushed
the
improve_slurm_service
branch
4 times, most recently
from
bd7d6b7
to
fe0487e
Compare
|
I pushed a wrapper-based update. |
| config = mkIf (cfg.client.enable || cfg.server.enable) { | ||
| config = | ||
| let | ||
| wrappedSlurm = pkgs.stdenv.mkDerivation { |
There was a problem hiding this comment.
Users will be able to run srun?
There was a problem hiding this comment.
Yes, if you look here, you see that cfg.package is not added to environment.systemPackages, only wrappedSlurm is. So unless the administrator adds pkgs.slurm-llnl to the system (and then generates conflicts), srun will be available via the wrapper script.
The test should show that it works (in this case root runs srun, I can improve it to have a regular user run srun if you prefer).
lsix
changed the title
|
👍 Please rename commit to |
lsix
force-pushed
the
improve_slurm_service
branch
from
fe0487e
to
4994f0f
Compare
|
I separated it in 2 commits. One for the configuration update and one for the tests additions. |
Improve slurm service configuration
In the current way
slurmis configured, I cannot run user-space commands (such assinfo) without having to specify where the slurm conf file is (it is not enough to specify it for the services).I see 3 options so solve this:
— Always have slum read its configuration in
/etc/slurm.conf(and maintain the config file withenvironment.etc."slurm.conf"I guess)— Have the default environment define
SLURM_CONFas a system-wide config (the only place I can think of is/etc/profilebut I do not see a conviniant way to do it since it is produced in abashrelated derivation)— Generate in the store a folder containing the configuration and use as
sysconfigdirwhen buildingslurm(but a new configuration implies a now folder to store it, and therefore a new derivation instanciation for slurm it-self)In this PR, I opted for the 3rd option, but it will necessarily induce compilation for all final users when they will try to configure slurm. If another option should be preferred, please let me know.