-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hunter: init at 1.3.5 #120084
hunter: init at 1.3.5 #120084
Conversation
Result of 1 package built:
|
@fufexan Thanks! Unfortunately, when trying to build it, I get:
Any ideas? |
@magnetophon are you building on
|
Result of 1 package failed to build:Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
@fufexan Yes, 64 bit linux. Odd, @r-rmcgibbo got a different error, at first glance. |
@magnetophon What I can gather from your output, specifically this
is that the command has some kind of problem with memory. Though I'm not sure what specifically. People with more experience in Rust may be able to help us. Or it may be like you said, a problem with your build machine. Try building on another computer if you can. @r-rmcgibbo It looks like ofborg also failed to build on |
I just found out that zfs has detected an error on I'll go look up how to force a rebuild. |
Build fails on x86_64-darwin, you need to add |
@OPNA2608 I hope it's better now. If not, please correct me. |
I built it using Thanks! |
Hm? How did it compile for me?
Despite there not being any changes in between 🤔 |
@legendofmiracles magnetophon had issues because of his build machine. OPNA2608 had issues because he's on darwin, and I forgot to add some deps. For r-rmcgibbo it didn't compile because they built it on aarch64 which is currently not supported by hunter. All of these issues had nothing to do with 64bit linux, that's why it built for you from the first try. If I had any other machines rather than @OPNA2608 that's weird, I haven't had that happen. Though it's good to know that it now builds on darwin too. 🙂 |
Glad we could test it all possible operating systems and architectures 😄 |
I've tried adding patches as @SuperSandro2000 suggested, however the build fails to use { lib
, stdenv
, pkg-config
, rustPlatform
, fetchFromGitHub
, fetchpatch
, makeWrapper
, glib
, gst_all_1
, CoreServices
, IOKit
, Security
}:
rustPlatform.buildRustPackage rec {
pname = "hunter";
version = "2020-05-25-unstable";
src = fetchFromGitHub {
owner = "rabite0";
repo = "hunter";
rev = "355d9a3101f6d8dc375807de79e368602f1cb87d";
sha256 = "sha256-R2wNkG8bFP7X2pdlebHK6GD15qmD/zD3L0MwVthvzzQ=";
};
patches = [
(fetchpatch {
name = "remove-dependencies-on-rust-nightly";
url =
"https://github.com/06kellyjac/hunter/commit/a5943578e1ee679c8bc51b0e686c6dddcf74da2a.diff";
sha256 = "sha256-eOwBFfW5m8tPnu+whWY/53X9CaqiVj2WRr25G+Yy7qE=";
})
(fetchpatch {
name = "fix-accessing-core-when-moved-with-another-clone";
url =
"https://github.com/06kellyjac/hunter/commit/2e95cc567c751263f8c318399f3c5bb01d36962a.diff";
sha256 = "sha256-yTzIXUw5qEaR2QZHwydg0abyZVXfK6fhJLVHBI7EAro=";
})
(fetchpatch {
name = "chore-cargo-update";
url =
"https://github.com/06kellyjac/hunter/commit/b0be49a82191a4420b6900737901a71140433efd.diff";
sha256 = "sha256-ctxoDwyIJgEhMbMUfrjCTy2SeMUQqMi971szrqEOJeg=";
})
(fetchpatch {
name = "chore-cargo-upgrade-+-cargo-update";
url =
"https://github.com/06kellyjac/hunter/commit/1b8de9248312878358afaf1dac569ebbccc4321a.diff";
sha256 = "sha256-+4DZ8SaKwKNmr2SEgJJ7KZBIctnYFMQFKgG+yCkbUv0=";
})
(fetchpatch {
name = "fix-resolve-breaking-changes-from-package-updates";
url =
"https://github.com/06kellyjac/hunter/commit/2484f0db580bed1972fd5000e1e949a4082d2f01.diff";
sha256 = "sha256-K+WUxEr1eE68XejStj/JwQpMHlhkiOw6PmiSr1GO0kc=";
})
];
RUSTC_BOOTSTRAP = 1;
nativeBuildInputs = [ makeWrapper pkg-config ];
buildInputs = [
glib
gst_all_1.gstreamer
gst_all_1.gst-plugins-base
gst_all_1.gst-plugins-good
gst_all_1.gst-plugins-ugly
gst_all_1.gst-plugins-bad
] ++ lib.optionals stdenv.isDarwin [ CoreServices IOKit Security ];
cargoBuildFlags = [ "--no-default-features" "--features=img,video" ];
postInstall = ''
wrapProgram $out/bin/hunter --prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0"
'';
cargoSha256 = "sha256-+1M22yQ8g9pKDYf5Zm9ae6oawoKB7kqFjykKbDeGDg8=";
meta = with lib; {
description = "The fastest file manager in the galaxy!";
homepage = "https://github.com/rabite0/hunter";
license = licenses.wtfpl;
maintainers = with maintainers; [ fufexan ];
};
} EDIT: solved with @OPNA2608's help again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 120084
run on x86_64-linux 1
1 package built:
- hunter
Binary launches but I have no clue how to navigate it.
Co-authored-by: Christoph Neidahl <christoph.neidahl@gmail.com>
Co-authored-by: Christoph Neidahl <christoph.neidahl@gmail.com>
Arrow keys / hjkl to get around dirs, |
Any news on this? Should I run ofborg again? |
@ofborg eval |
Motivation for this change
Add the hunter file manager. Builds on the work done in 99898, since @magnetophon isn't interested in maintaining this package anymore.
The maintainer of the project has disappeared, but there may be folks who decide to fork and continue its development. For this exact reason I have picked a fork as the repo, since it includes some fixes and allows building the package without Rust Nightly.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)